Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spotinst_aws_elasticgroup: sanity checks #5553

Merged
merged 5 commits into from
Nov 15, 2022
Merged

spotinst_aws_elasticgroup: sanity checks #5553

merged 5 commits into from
Nov 15, 2022

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Nov 15, 2022

SUMMARY

Fixed sanity checks for module.

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
COMPONENT NAME

plugins/modules/spotinst_aws_elastigroup.py

@ansibullbot
Copy link
Collaborator

cc @talzur
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug cloud module module plugins plugin (any type) tests tests labels Nov 15, 2022
felixfontein
felixfontein reviewed Nov 15, 2022
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a small comment:

@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-6 labels Nov 15, 2022
@github-actions
Copy link

github-actions bot commented Nov 15, 2022 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@russoz russoz changed the title Spotinst aws elasticgroup sanity spotinst_aws_elasticgroup: sanity checks Nov 15, 2022
@felixfontein felixfontein merged commit 270dc13 into ansible-collections:main Nov 15, 2022
@patchback
Copy link

patchback bot commented Nov 15, 2022 •
edited
Loading

Backport to stable-5: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 270dc13 on top of patchback/backports/stable-5/270dc133b3f4b030886d343f65694aa6bcd33457/pr-5553

Backporting merged PR #5553 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it: 
    $ git remote add upstream https://github.com/ansible-collections/community.general.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code: 
    $ git fetch upstream
$ git checkout -b patchback/backports/stable-5/270dc133b3f4b030886d343f65694aa6bcd33457/pr-5553 upstream/stable-5
  4. Now, cherry-pick PR spotinst_aws_elasticgroup: sanity checks #5553 contents into that branch: 
    $ git cherry-pick -x 270dc133b3f4b030886d343f65694aa6bcd33457
    If it'll yell at you with something like fatal: Commit 270dc133b3f4b030886d343f65694aa6bcd33457 is a merge but no -m option was given., add -m 1 as follows intead: 
    $ git cherry-pick -m1 -x 270dc133b3f4b030886d343f65694aa6bcd33457
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR spotinst_aws_elasticgroup: sanity checks #5553 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub: 
    $ git push origin patchback/backports/stable-5/270dc133b3f4b030886d343f65694aa6bcd33457/pr-5553
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@russoz thanks!

@patchback
Copy link

patchback bot commented Nov 15, 2022 •
edited
Loading

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/270dc133b3f4b030886d343f65694aa6bcd33457/pr-5553

Backported as #5554

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 15, 2022
@russoz @patchback
spotinst_aws_elasticgroup: sanity checks (#5553)
a02b99c 
* spotinst_aws_elastigroup: add elements to parameter do_not_update

* spotinst_aws_elastigroup: add docs for parameter token

* add missing docs

* add changelog fragment

* Update plugins/modules/spotinst_aws_elastigroup.py

Co-authored-by: Felix Fontein <[email protected]>

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 270dc13)
@patchback patchback bot mentioned this pull request Nov 15, 2022
Merged
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Nov 15, 2022
@russoz russoz deleted the spotinst-aws-elasticgroup-sanity branch November 15, 2022 21:40
felixfontein pushed a commit that referenced this pull request Nov 16, 2022
@patchback @russoz
spotinst_aws_elasticgroup: sanity checks (#5553) (#5554)
41a23f0 
* spotinst_aws_elastigroup: add elements to parameter do_not_update

* spotinst_aws_elastigroup: add docs for parameter token

* add missing docs

* add changelog fragment

* Update plugins/modules/spotinst_aws_elastigroup.py

Co-authored-by: Felix Fontein <[email protected]>

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 270dc13)

Co-authored-by: Alexei Znamensky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug cloud module module plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@russoz @ansibullbot @felixfontein