bugfixing keycloak user federation failing when updating default mapper simultaneously #5750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... user federation creation failing when also updating/changing default mappers at the same time
morco
changed the title
ansibullbot
added
WIP
felixfontein
added
check-before-release
russoz
approved these changes
Jan 7, 2023
|
Same from my POV. If nobody objects in the next two weeks, I'll merge this. |
felixfontein
removed
the
check-before-release
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #5875 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jan 22, 2023
…er simultaneously (#5750) * fix(modules/keycloak_user_federation): fixes ... ... user federation creation failing when also updating/changing default mappers at the same time * add changelog fragment for pr Co-authored-by: Mirko Wilhelmi <[email protected]> (cherry picked from commit 6781dd1)
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #5876 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jan 22, 2023
…er simultaneously (#5750) * fix(modules/keycloak_user_federation): fixes ... ... user federation creation failing when also updating/changing default mappers at the same time * add changelog fragment for pr Co-authored-by: Mirko Wilhelmi <[email protected]> (cherry picked from commit 6781dd1)
felixfontein
pushed a commit
that referenced
this pull request
Jan 22, 2023
…tion failing when updating default mapper simultaneously (#5875) bugfixing keycloak user federation failing when updating default mapper simultaneously (#5750) * fix(modules/keycloak_user_federation): fixes ... ... user federation creation failing when also updating/changing default mappers at the same time * add changelog fragment for pr Co-authored-by: Mirko Wilhelmi <[email protected]> (cherry picked from commit 6781dd1) Co-authored-by: morco <[email protected]>
felixfontein
pushed a commit
that referenced
this pull request
Jan 22, 2023
…tion failing when updating default mapper simultaneously (#5876) bugfixing keycloak user federation failing when updating default mapper simultaneously (#5750) * fix(modules/keycloak_user_federation): fixes ... ... user federation creation failing when also updating/changing default mappers at the same time * add changelog fragment for pr Co-authored-by: Mirko Wilhelmi <[email protected]> (cherry picked from commit 6781dd1) Co-authored-by: morco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Current implementation of
keycloak_user_federationmodule fails to create a new user federation when also simultaneously updating / changing a default / standard created mapper likeusername.The cause of this as can be seen in the diffs is simply a variable set to
Noneon default forgotten to be updated to proper id value.It seems there are currently no open issues matching this bug or at least I failed to find them.
ISSUE TYPE
COMPONENT NAME
plugins/modules/keycloak_user_federation.py
ADDITIONAL INFORMATION
Tested with recent keycloak (api) version:
20.0.2.