ModuleHelper - lax handling of conflicting output #5765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
feature
felixfontein
reviewed
Jan 5, 2023
tests/integration/targets/module_helper/tasks/msimple_output_conflict.yml
Outdated
Show resolved
Hide resolved
felixfontein
added
check-before-release
felixfontein
reviewed
Jan 5, 2023
tests/integration/targets/module_helper/tasks/msimple_output_conflict.yml
Show resolved
Hide resolved
ansibullbot
added
the
needs_revision
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
ansibullbot
removed
the
needs_revision
felixfontein
reviewed
Jan 6, 2023
Co-authored-by: Felix Fontein <[email protected]>
felixfontein
approved these changes
Jan 7, 2023
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #5775 🤖 @patchback |
felixfontein
removed
the
check-before-release
patchback bot
pushed a commit
that referenced
this pull request
Jan 7, 2023
* ModuleHelper - lax handling of conflicting output * add changelog fragment * only create _var when really needed * adjust changelog * Update changelogs/fragments/5765-mh-lax-output-conflict.yml Co-authored-by: Felix Fontein <[email protected]> Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit dc531b1)
|
@russoz thanks! |
felixfontein
pushed a commit
that referenced
this pull request
Jan 7, 2023
… conflicting output (#5775) ModuleHelper - lax handling of conflicting output (#5765) * ModuleHelper - lax handling of conflicting output * add changelog fragment * only create _var when really needed * adjust changelog * Update changelogs/fragments/5765-mh-lax-output-conflict.yml Co-authored-by: Felix Fontein <[email protected]> Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit dc531b1) Co-authored-by: Alexei Znamensky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Change ModuleHelper behaviour when handling output variables using protected names, allowing the module to set them if unused by MH.
ISSUE TYPE
COMPONENT NAME
plugins/module_utils/mh/deco.py
plugins/module_utils/mh/module_helper.py