OpenNebula/one_vm implement the one.vm.updateconf API call #5812

sk4zuzu · 2023-01-10T11:25:50Z

SUMMARY

OpenNebula provides the one.vm.updateconf API call, that can be used to modify the context of a VM. For example SSH_PUBLIC_KEY, PASSWORD or even START_SCRIPT variables can be set. This PR implements exactly that, it allows for updating running VMs and setting the same parameters for freshly created ones. We believe this can prove useful for some users.

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

one_vm module

ADDITIONAL INFORMATION

NA

ansibullbot · 2023-01-10T11:26:39Z

cc @ilicmilan @meerkampdvv @nilsding @rsmontero @xorel
click here for bot help

github-actions · 2023-01-10T11:39:26Z

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

russoz

Hi @sk4zuzu
Thank you for the contribution! Please add a changelog fragment.

I saw you wrote tests, but only for the module_utils stuff. It would be great if you could think of tests to the actual update_conf() code. It might be something for another PR though, I will defer that decision to your judgement.

Cheers

plugins/module_utils/opennebula.py

plugins/modules/one_vm.py

tests/unit/plugins/module_utils/test_opennebula.py

Co-authored-by: Alexei Znamensky <[email protected]>

sk4zuzu · 2023-01-11T12:09:01Z

Hello @russoz

Thank you for the review.

Please add a changelog fragment.

Done. :)

I saw you wrote tests, but only for the module_utils stuff. It would be great if you could think of tests to the actual update_conf() code. It might be something for another PR though, I will defer that decision to your judgement.

Actually I was thinking about it and concluded this should be some other PR, that's because there were no tests for one_vm module of any kind. I'd rather create something more comprehensive for the whole module if you won't mind. 🤔

The CI checks fail for python2.6, is it something that needs to addressed? I believe python 2.6 is not listed here. 🤔

Cheers

felixfontein · 2023-01-12T20:30:34Z

The CI checks fail for python2.6, is it something that needs to addressed? I believe python 2.6 is not listed here. thinking

Yes, this needs to be adressed (otherwise CI wouldn't complain). ansible-core 2.11 (which this collection still supports) supports Python 2.6.

felixfontein

Thanks for your contribution. I've added some comments.

changelogs/fragments/5812-implement-updateconf-api-call.yml

plugins/modules/one_vm.py

Co-authored-by: Felix Fontein <[email protected]>

felixfontein

I'm not familiar with this codebase, but from a generic Ansible POV this looks ok. If nobody objects in the next two weeks, I'll merge this.

patchback · 2023-01-28T10:29:04Z

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/8818a6f2421d50980229db464a710a84e4748eff/pr-5812

Backported as #5905

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

* opennebula: Add template manipulation helpers * one_vm: Use 'updateconf' API call to modify running VMs * one_vm: Emulate 'updateconf' API call for newly created VMs * opennebula/one_vm: Satisfy linter checks * opennebula/one_vm: Apply suggestions from code review Co-authored-by: Alexei Znamensky <[email protected]> * opennebula/one_vm: Drop 'extend' function, use 'dict_merge' instead * Add changelog fragment * one_vm: Refactor 'parse_updateconf' function * opennebula/one_vm: Apply suggestions from code review Co-authored-by: Felix Fontein <[email protected]> * one_vm: Allow for using updateconf in all scenarios --------- Co-authored-by: Alexei Znamensky <[email protected]> Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 8818a6f)

felixfontein · 2023-01-28T10:29:15Z

@sk4zuzu thanks for your contribution!
@russoz thanks for reviewing!

…e one.vm.updateconf API call (#5905) OpenNebula/one_vm implement the one.vm.updateconf API call (#5812) * opennebula: Add template manipulation helpers * one_vm: Use 'updateconf' API call to modify running VMs * one_vm: Emulate 'updateconf' API call for newly created VMs * opennebula/one_vm: Satisfy linter checks * opennebula/one_vm: Apply suggestions from code review Co-authored-by: Alexei Znamensky <[email protected]> * opennebula/one_vm: Drop 'extend' function, use 'dict_merge' instead * Add changelog fragment * one_vm: Refactor 'parse_updateconf' function * opennebula/one_vm: Apply suggestions from code review Co-authored-by: Felix Fontein <[email protected]> * one_vm: Allow for using updateconf in all scenarios --------- Co-authored-by: Alexei Znamensky <[email protected]> Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 8818a6f) Co-authored-by: Michal Opala <[email protected]>

sk4zuzu added 4 commits January 9, 2023 21:32

opennebula: Add template manipulation helpers

db4c139

one_vm: Use 'updateconf' API call to modify running VMs

85f352a

one_vm: Emulate 'updateconf' API call for newly created VMs

e42eaa0

opennebula/one_vm: Satisfy linter checks

8be4526

ansibullbot added cloud feature This issue/PR relates to a feature request module module module_utils module_utils new_contributor Help guide this first time contributor new_plugin New plugin plugins plugin (any type) tests tests unit tests/unit labels Jan 10, 2023

This comment was marked as outdated.

Sign in to view

ansibullbot added ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jan 10, 2023

russoz reviewed Jan 11, 2023

View reviewed changes

plugins/module_utils/opennebula.py Outdated Show resolved Hide resolved

plugins/modules/one_vm.py Outdated Show resolved Hide resolved

tests/unit/plugins/module_utils/test_opennebula.py Outdated Show resolved Hide resolved

opennebula/one_vm: Apply suggestions from code review

2b6c8fb

Co-authored-by: Alexei Znamensky <[email protected]>

ansibullbot added ci_verified Push fixes to PR branch to re-run CI and removed ci_verified Push fixes to PR branch to re-run CI labels Jan 11, 2023

sk4zuzu added 2 commits January 11, 2023 12:39

opennebula/one_vm: Drop 'extend' function, use 'dict_merge' instead

662c541

Add changelog fragment

0a4ab11

ansibullbot removed the ci_verified Push fixes to PR branch to re-run CI label Jan 11, 2023

This comment was marked as outdated.

Sign in to view

ansibullbot added the ci_verified Push fixes to PR branch to re-run CI label Jan 11, 2023

felixfontein reviewed Jan 12, 2023

View reviewed changes

felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-6 labels Jan 12, 2023

one_vm: Refactor 'parse_updateconf' function

e12c50e

ansibullbot removed ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jan 13, 2023

sk4zuzu and others added 2 commits January 13, 2023 14:04

opennebula/one_vm: Apply suggestions from code review

75c4ece

Co-authored-by: Felix Fontein <[email protected]>

one_vm: Allow for using updateconf in all scenarios

c11167d

felixfontein approved these changes Jan 15, 2023

View reviewed changes

ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Jan 23, 2023

felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jan 28, 2023

felixfontein merged commit 8818a6f into ansible-collections:main Jan 28, 2023

patchback bot mentioned this pull request Jan 28, 2023

[PR #5812/8818a6f2 backport][stable-6] OpenNebula/one_vm implement the one.vm.updateconf API call #5905

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OpenNebula/one_vm implement the one.vm.updateconf API call #5812

OpenNebula/one_vm implement the one.vm.updateconf API call #5812

sk4zuzu commented Jan 10, 2023

ansibullbot commented Jan 10, 2023

This comment was marked as outdated.

github-actions bot commented Jan 10, 2023 •

edited

Loading

russoz left a comment

This comment was marked as outdated.

sk4zuzu commented Jan 11, 2023

felixfontein commented Jan 12, 2023

felixfontein left a comment

felixfontein left a comment

patchback bot commented Jan 28, 2023 •

edited

Loading

felixfontein commented Jan 28, 2023

OpenNebula/one_vm implement the one.vm.updateconf API call #5812

OpenNebula/one_vm implement the one.vm.updateconf API call #5812

Conversation

sk4zuzu commented Jan 10, 2023

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

ansibullbot commented Jan 10, 2023

This comment was marked as outdated.

github-actions bot commented Jan 10, 2023 • edited Loading

Docs Build 📝

russoz left a comment

Choose a reason for hiding this comment

This comment was marked as outdated.

sk4zuzu commented Jan 11, 2023

felixfontein commented Jan 12, 2023

felixfontein left a comment

Choose a reason for hiding this comment

felixfontein left a comment

Choose a reason for hiding this comment

patchback bot commented Jan 28, 2023 • edited Loading

Backport to stable-6: 💚 backport PR created

felixfontein commented Jan 28, 2023

github-actions bot commented Jan 10, 2023 •

edited

Loading

patchback bot commented Jan 28, 2023 •

edited

Loading