Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gem: Support force flag when uninstalling #5822

Merged

Conversation

juan-vg
Copy link
Contributor

@juan-vg juan-vg commented Jan 12, 2023

SUMMARY

Allow to use the --force flag when uninstalling gems. This is useful because when there are dependencies the gem binary will interactively ask for user confirmation and Ansible will hang forever.

Fixes #5821

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

gem

ADDITIONAL INFORMATION

As can be seen on the picture below, gem uninstall implements the --force flag.

imagen

@ansibullbot
Copy link
Collaborator

cc @None @johanwiren
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug language module module new_contributor Help guide this first time contributor packaging plugins plugin (any type) small_patch Hopefully easy to review labels Jan 12, 2023
@github-actions
Copy link

github-actions bot commented Jan 12, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@felixfontein
Copy link
Collaborator

CC @rietvelde who recently also worked on this module.

Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Could you please add a changelog fragment? Thanks.

@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-6 labels Jan 12, 2023
@juan-vg
Copy link
Contributor Author

juan-vg commented Jan 13, 2023

@felixfontein done!

@ansibullbot ansibullbot removed the small_patch Hopefully easy to review label Jan 13, 2023
@felixfontein
Copy link
Collaborator

If nobody objects, I'll merge this in ~one week.

Copy link
Collaborator

@russoz russoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jan 24, 2023
@felixfontein felixfontein merged commit fe520a6 into ansible-collections:main Jan 24, 2023
@patchback
Copy link

patchback bot commented Jan 24, 2023

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/fe520a6b09aeab283f1477556b49cb64386a8e10/pr-5822

Backported as #5884

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 24, 2023
* Gem: Support force flag when uninstalling

* Improve docs' syntax

* Add changelog fragment

(cherry picked from commit fe520a6)
@felixfontein
Copy link
Collaborator

@juan-vg thanks for your contribution!
@russoz thanks for reviewing!

felixfontein pushed a commit that referenced this pull request Jan 24, 2023
…ninstalling (#5884)

Gem: Support force flag when uninstalling (#5822)

* Gem: Support force flag when uninstalling

* Improve docs' syntax

* Add changelog fragment

(cherry picked from commit fe520a6)

Co-authored-by: Juan Vela <[email protected]>
@juan-vg juan-vg deleted the feature/gem-uninstall-force branch January 25, 2023 08:33
@juan-vg juan-vg restored the feature/gem-uninstall-force branch January 25, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug language module module new_contributor Help guide this first time contributor packaging plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gem: Force is not working when uninstalling
4 participants