Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apt_rpm: add clean, dist_upgrade and update_kernel #5867

Merged
merged 1 commit into from
Mar 25, 2023

Conversation

sibskull
Copy link
Contributor

  • clean performs apt-get clean.

  • upgrade performs apt-get dist-upgrade.

  • update_cache, clean and upgrade can be used with and without specified packages.

@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added module module new_contributor Help guide this first time contributor os packaging plugins plugin (any type) labels Jan 22, 2023
@ansibullbot

This comment was marked as outdated.

@ansibullbot ansibullbot added ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jan 22, 2023
@github-actions
Copy link

github-actions bot commented Jan 22, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot

This comment was marked as outdated.

@ansibullbot ansibullbot removed ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jan 22, 2023
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-6 labels Jan 22, 2023
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Can you please add a changelog fragment? Thanks.

@sibskull sibskull force-pushed the main branch 3 times, most recently from 2d00ce7 to 70daee6 Compare January 26, 2023 08:32
@ansibullbot ansibullbot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Jan 26, 2023
@sibskull sibskull changed the title apt_rpm: add clean and upgrade apt_rpm: add clean and dist_upgrade Jan 26, 2023
@ansibullbot ansibullbot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Jan 26, 2023
@sibskull
Copy link
Contributor Author

What's wrong with tests?

@felixfontein
Copy link
Collaborator

Not sure what you mean, as CI has passed.

@sibskull sibskull changed the title apt_rpm: add clean and dist_upgrade apt_rpm: add clean, dist_upgrade and update_kernel Feb 4, 2023
@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Feb 13, 2023
@ansibullbot ansibullbot removed the stale_ci CI is older than 7 days, rerun before merging label Feb 28, 2023
@ansibullbot

This comment was marked as outdated.

@ansibullbot ansibullbot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Feb 28, 2023
@ansibullbot ansibullbot added the ci_verified Push fixes to PR branch to re-run CI label Feb 28, 2023
@ansibullbot ansibullbot removed the ci_verified Push fixes to PR branch to re-run CI label Feb 28, 2023
@ansibullbot

This comment was marked as outdated.

@ansibullbot ansibullbot added the ci_verified Push fixes to PR branch to re-run CI label Feb 28, 2023
@ansibullbot

This comment was marked as outdated.

@ansibullbot ansibullbot removed ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Feb 28, 2023
@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Mar 9, 2023
@sibskull
Copy link
Contributor Author

Any other comments?

Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'll merge this in a week if nobody objects (with the suggestions added).

* clean performs apt-get clean.

* dist_upgrade performs apt-get dist-upgrade.

* update_kernel performs update-kernel to upgrade kernel packages.

* update_cache, clean, dist_upgrade and update_kernel can be used with and without specified packages.
@ansibullbot ansibullbot removed the stale_ci CI is older than 7 days, rerun before merging label Mar 19, 2023
@felixfontein felixfontein merged commit b1d9438 into ansible-collections:main Mar 25, 2023
@patchback
Copy link

patchback bot commented Mar 25, 2023

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/b1d94385ae52a824ac65bc7021254cbaf6087626/pr-5867

Backported as #6233

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Mar 25, 2023
patchback bot pushed a commit that referenced this pull request Mar 25, 2023
* clean performs apt-get clean.

* dist_upgrade performs apt-get dist-upgrade.

* update_kernel performs update-kernel to upgrade kernel packages.

* update_cache, clean, dist_upgrade and update_kernel can be used with and without specified packages.

(cherry picked from commit b1d9438)
@felixfontein
Copy link
Collaborator

@sibskull thanks a lot for your contriubtion!

felixfontein pushed a commit that referenced this pull request Mar 25, 2023
…de and update_kernel (#6233)

apt_rpm: add clean, dist_upgrade and update_kernel (#5867)

* clean performs apt-get clean.

* dist_upgrade performs apt-get dist-upgrade.

* update_kernel performs update-kernel to upgrade kernel packages.

* update_cache, clean, dist_upgrade and update_kernel can be used with and without specified packages.

(cherry picked from commit b1d9438)

Co-authored-by: Andrey Cherepanov <[email protected]>
@sibskull
Copy link
Contributor Author

Thank you for your patient advices!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module module new_contributor Help guide this first time contributor os packaging plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants