nmcli: fixed idempotency issue with 'may_fail4' when 'method' is 'disabled' #6106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…abled' * added note to documentation
ansibullbot
added
bug
Docs Build 📝Thank you for contribution!✨ The docsite for this PR is available for download as an artifact from this run: File changes:
Click to see the diff comparison.NOTE: only file modifications are shown here. New and deleted files are excluded. diff --git a/home/runner/work/community.general/community.general/docsbuild/base/collections/community/general/nmcli_module.html b/home/runner/work/community.general/community.general/docsbuild/head/collections/community/general/nmcli_module.html
index 967b91b..050f2be 100644
--- a/home/runner/work/community.general/community.general/docsbuild/base/collections/community/general/nmcli_module.html
+++ b/home/runner/work/community.general/community.general/docsbuild/head/collections/community/general/nmcli_module.html
@@ -675,6 +675,7 @@ see <a class="reference internal" href="#ansible-collections-community-general-n
<p><span class="ansible-option-versionadded">added in community.general 3.3.0</span></p>
</div></td>
<td><div class="ansible-option-cell"><p>If you need <em>ip4</em> configured before <code class="docutils literal notranslate"><span class="pre">network-online.target</span></code> is reached, set this option to <code class="docutils literal notranslate"><span class="pre">false</span></code>.</p>
+<p>This option applies when <code class="docutils literal notranslate"><span class="pre">method4</span></code> is not <code class="docutils literal notranslate"><span class="pre">disabled</span></code>.</p>
<p class="ansible-option-line"><span class="ansible-option-choices">Choices:</span></p>
<ul class="simple">
<li><p><code class="ansible-option-choices-entry docutils literal notranslate"><span class="pre">false</span></code></p></li>
|
felixfontein
added
check-before-release
ansibullbot
added
stale_ci
This was referenced Mar 19, 2023
Merged
changelogs/fragments/6106-nmcli-ipv4-mayfail-idempotency-fix.yml
Outdated
Show resolved
Hide resolved
|
If nobody objects, I'll merge this this weekend as well. |
felixfontein
removed
the
check-before-release
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #6240 🤖 @patchback |
|
@heaveaxy thanks for your contribution! |
patchback bot
pushed a commit
that referenced
this pull request
Mar 26, 2023
…abled' (#6106) * nmcli: fixed idempotency issue with 'may_fail4' when 'method' is 'disabled' * added note to documentation * updated changelog fragment * Update changelog fragment. --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 5ee6870)
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #6241 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Mar 26, 2023
…abled' (#6106) * nmcli: fixed idempotency issue with 'may_fail4' when 'method' is 'disabled' * added note to documentation * updated changelog fragment * Update changelog fragment. --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 5ee6870)
felixfontein
pushed a commit
that referenced
this pull request
Mar 26, 2023
… with 'may_fail4' when 'method' is 'disabled' (#6241) nmcli: fixed idempotency issue with 'may_fail4' when 'method' is 'disabled' (#6106) * nmcli: fixed idempotency issue with 'may_fail4' when 'method' is 'disabled' * added note to documentation * updated changelog fragment * Update changelog fragment. --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 5ee6870) Co-authored-by: Sam Potekhin <[email protected]>
felixfontein
pushed a commit
that referenced
this pull request
Mar 26, 2023
… with 'may_fail4' when 'method' is 'disabled' (#6240) nmcli: fixed idempotency issue with 'may_fail4' when 'method' is 'disabled' (#6106) * nmcli: fixed idempotency issue with 'may_fail4' when 'method' is 'disabled' * added note to documentation * updated changelog fragment * Update changelog fragment. --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 5ee6870) Co-authored-by: Sam Potekhin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
If
method4wasdisabled, this option has no effect - nmcli accepts it, but keeps it's own default value. Task marked changed always because ofdiffwith default value and passed to module.Now option
ipv4.may-failparticipate in configuration process only when user definedmethod4as non-disabled.ISSUE TYPE
COMPONENT NAME
nmcli