Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated error with BadZipFile #6180

Merged
merged 4 commits into from
Mar 22, 2023
Merged

Replace deprecated error with BadZipFile #6180

merged 4 commits into from
Mar 22, 2023

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Mar 12, 2023

SUMMARY

BadZipfile (with a small f) has been deprecated since Python 3.2, use BadZipFile (big F) instead, added in 3.2.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

archive

ADDITIONAL INFORMATION

See also ansible/ansible#80198.

@hugovk hugovk mentioned this pull request Mar 12, 2023
Merged
@ansibullbot
Copy link
Collaborator

cc @bendoh
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug files module module new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review labels Mar 12, 2023
@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot ansibullbot added ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Mar 12, 2023
felixfontein
felixfontein reviewed Mar 12, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Could you please add a changelog fragment? Thanks!

@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-5 labels Mar 12, 2023
hugovk and others added 2 commits March 12, 2023 22:42
@hugovk
Copy link
Contributor Author

hugovk commented Mar 12, 2023

Fragment added!

@ansibullbot ansibullbot removed ci_verified Push fixes to PR branch to re-run CI small_patch Hopefully easy to review needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Mar 12, 2023
@hugovk @felixfontein
Update new fragment
0378662 
Co-authored-by: Felix Fontein <[email protected]>
@ansibullbot ansibullbot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Mar 14, 2023
felixfontein
felixfontein approved these changes Mar 14, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. If nobody objects, I'll merge in ~a week.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Mar 22, 2023
@felixfontein felixfontein merged commit f66cc7c into ansible-collections:main Mar 22, 2023
@patchback
Copy link

patchback bot commented Mar 22, 2023 •
edited
Loading

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/f66cc7c933316c9c0094564d4b143df58375c2f8/pr-6180

Backported as #6215

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@hugovk thanks for your contribution!

patchback bot pushed a commit that referenced this pull request Mar 22, 2023
@hugovk @patchback
Replace deprecated error with BadZipFile (#6180)
ea5d6d9 
* Replace deprecated error with BadZipFile

* Use imported BadZipFile

Co-authored-by: Felix Fontein <[email protected]>

* Add news fragment

* Update new fragment

Co-authored-by: Felix Fontein <[email protected]>

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit f66cc7c)
@patchback patchback bot mentioned this pull request Mar 22, 2023
Merged
@patchback
Copy link

patchback bot commented Mar 22, 2023 •
edited
Loading

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/f66cc7c933316c9c0094564d4b143df58375c2f8/pr-6180

Backported as #6216

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 22, 2023
@hugovk @patchback
Replace deprecated error with BadZipFile (#6180)
0ef2eb9 
* Replace deprecated error with BadZipFile

* Use imported BadZipFile

Co-authored-by: Felix Fontein <[email protected]>

* Add news fragment

* Update new fragment

Co-authored-by: Felix Fontein <[email protected]>

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit f66cc7c)
@patchback patchback bot mentioned this pull request Mar 22, 2023
Merged
@github-actions
Copy link

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@hugovk hugovk deleted the replace-deprecated-BadZipfile branch March 22, 2023 10:06
felixfontein pushed a commit that referenced this pull request Mar 22, 2023
@patchback @hugovk
[PR #6180/f66cc7c9 backport][stable-5] Replace deprecated error with …
3e74011 
…BadZipFile (#6215)

Replace deprecated error with BadZipFile (#6180)

* Replace deprecated error with BadZipFile

* Use imported BadZipFile

Co-authored-by: Felix Fontein <[email protected]>

* Add news fragment

* Update new fragment

Co-authored-by: Felix Fontein <[email protected]>

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit f66cc7c)

Co-authored-by: Hugo van Kemenade <[email protected]>
felixfontein pushed a commit that referenced this pull request Mar 22, 2023
@patchback @hugovk
[PR #6180/f66cc7c9 backport][stable-6] Replace deprecated error with …
ad6c280 
…BadZipFile (#6216)

Replace deprecated error with BadZipFile (#6180)

* Replace deprecated error with BadZipFile

* Use imported BadZipFile

Co-authored-by: Felix Fontein <[email protected]>

* Add news fragment

* Update new fragment

Co-authored-by: Felix Fontein <[email protected]>

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit f66cc7c)

Co-authored-by: Hugo van Kemenade <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug files module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hugovk @ansibullbot @felixfontein