-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added hpe thermal config and fan percent min #6208
added hpe thermal config and fan percent min #6208
Conversation
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
This functionality could be exposed with a standard "Control" resource rather than going through OEM extensions. However, the "Control" model is much newer and very likely not implemented on the system you're using. Is there a real need to override these thermal settings though? Typically the manufacturer doesn't want a customer to change these settings since they're all governed by the manager internally. |
Whoops, missed the context; these are all "GET" operations to extract the data (no PATCH operations). This makes me feel much better. |
Yeah. We use this simply to ensure unified configs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! Please add a changelog fragment. Thanks.
Other than the changelog fragment, this looks good to me |
|
This comment was marked as outdated.
This comment was marked as outdated.
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #6237 🤖 @patchback |
* added hpe thermal config and fan percent min * typo fixed * Create 6208-hpe-thermal-fan-percent.yaml * fixed changelog fragment * Update 6208-hpe-thermal-fan-percent.yaml (cherry picked from commit 33ccabe)
@superky13 thanks for your contribution! |
…an percent min (#6237) added hpe thermal config and fan percent min (#6208) * added hpe thermal config and fan percent min * typo fixed * Create 6208-hpe-thermal-fan-percent.yaml * fixed changelog fragment * Update 6208-hpe-thermal-fan-percent.yaml (cherry picked from commit 33ccabe) Co-authored-by: ky13 <[email protected]>
SUMMARY
Added two additional functions that we use to retrieve ThermalConfiguration and FanPercentMinimum settings (via iLO) on our HPE Gen 10/10+ boxes.
ISSUE TYPE
COMPONENT NAME
redfish_info.py
redfish_utils.py
ADDITIONAL INFORMATION