icinga2_host: fix a key error when modifying an existing host #6748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yoannlr this PR contains the following merge commits: Please rebase your branch to remove these commits. |
ansibullbot
added
bug
…ars.yml Co-authored-by: Felix Fontein <[email protected]>
ansibullbot
added
plugins
felixfontein
added
check-before-release
felixfontein
approved these changes
Jun 20, 2023
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #6752 🤖 @patchback |
felixfontein
removed
the
check-before-release
patchback bot
pushed a commit
that referenced
this pull request
Jun 20, 2023
* Initialize `template` variable. Add changelog fragment. * Update changelogs/fragments/6286-icinga2_host-template-and-template-vars.yml Co-authored-by: Felix Fontein <[email protected]> * icinga2_host: fix a key error when updating a host * Changelog fragment. * Update changelog fragment with correct PR number. --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 806f6da)
|
@yoannlr thanks for fixing this! |
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #6753 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jun 20, 2023
* Initialize `template` variable. Add changelog fragment. * Update changelogs/fragments/6286-icinga2_host-template-and-template-vars.yml Co-authored-by: Felix Fontein <[email protected]> * icinga2_host: fix a key error when updating a host * Changelog fragment. * Update changelog fragment with correct PR number. --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 806f6da)
felixfontein
pushed a commit
that referenced
this pull request
Jun 20, 2023
…when modifying an existing host (#6752) icinga2_host: fix a key error when modifying an existing host (#6748) * Initialize `template` variable. Add changelog fragment. * Update changelogs/fragments/6286-icinga2_host-template-and-template-vars.yml Co-authored-by: Felix Fontein <[email protected]> * icinga2_host: fix a key error when updating a host * Changelog fragment. * Update changelog fragment with correct PR number. --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 806f6da) Co-authored-by: yoannlr <[email protected]>
felixfontein
pushed a commit
that referenced
this pull request
Jun 20, 2023
…when modifying an existing host (#6753) icinga2_host: fix a key error when modifying an existing host (#6748) * Initialize `template` variable. Add changelog fragment. * Update changelogs/fragments/6286-icinga2_host-template-and-template-vars.yml Co-authored-by: Felix Fontein <[email protected]> * icinga2_host: fix a key error when updating a host * Changelog fragment. * Update changelog fragment with correct PR number. --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 806f6da) Co-authored-by: yoannlr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
In my previous PR #6286, I forgot to change a line responsible for updating an existing Icinga host object with the correct data structure. This results in an error if the host we try to add/update using the
icinga2_hostmodule already exists in Icinga.ISSUE TYPE
COMPONENT NAME
icinga2_host module
ADDITIONAL INFORMATION