Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rhsm_repository: add an initial unit test #6758

Merged

Conversation

ptoscano
Copy link
Contributor

SUMMARY

So far there are no tests for the rhsm_repository module, which makes it difficult to do even basic changes. Hence, add an initial version of unit tests, heavily based on the approach of the redhat_subscription unit tests.

ISSUE TYPE
  • Test Pull Request
COMPONENT NAME

rhsm_repository

So far there are no tests for the rhsm_repository module, which makes it
difficult to do even basic changes. Hence, add an initial version of
unit tests, heavily based on the approach of the redhat_subscription
unit tests.
@ansibullbot ansibullbot added new_plugin New plugin tests tests unit tests/unit labels Jun 21, 2023
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-6 labels Jun 21, 2023
@richm
Copy link

richm commented Jun 23, 2023

lgtm - nice

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jun 24, 2023
@felixfontein felixfontein merged commit 08fa05f into ansible-collections:main Jun 24, 2023
@patchback
Copy link

patchback bot commented Jun 24, 2023

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/08fa05f05f05cb2c5a62d4e4f22e8d7ff92f5eca/pr-6758

Backported as #6780

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jun 24, 2023
So far there are no tests for the rhsm_repository module, which makes it
difficult to do even basic changes. Hence, add an initial version of
unit tests, heavily based on the approach of the redhat_subscription
unit tests.

(cherry picked from commit 08fa05f)
@felixfontein
Copy link
Collaborator

@ptoscano thanks for your contribution!
@richm thanks for reviewing!

@patchback
Copy link

patchback bot commented Jun 24, 2023

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/08fa05f05f05cb2c5a62d4e4f22e8d7ff92f5eca/pr-6758

Backported as #6781

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jun 24, 2023
So far there are no tests for the rhsm_repository module, which makes it
difficult to do even basic changes. Hence, add an initial version of
unit tests, heavily based on the approach of the redhat_subscription
unit tests.

(cherry picked from commit 08fa05f)
felixfontein pushed a commit that referenced this pull request Jun 24, 2023
…l unit test (#6780)

rhsm_repository: add an initial unit test (#6758)

So far there are no tests for the rhsm_repository module, which makes it
difficult to do even basic changes. Hence, add an initial version of
unit tests, heavily based on the approach of the redhat_subscription
unit tests.

(cherry picked from commit 08fa05f)

Co-authored-by: Pino Toscano <[email protected]>
felixfontein pushed a commit that referenced this pull request Jun 24, 2023
…l unit test (#6781)

rhsm_repository: add an initial unit test (#6758)

So far there are no tests for the rhsm_repository module, which makes it
difficult to do even basic changes. Hence, add an initial version of
unit tests, heavily based on the approach of the redhat_subscription
unit tests.

(cherry picked from commit 08fa05f)

Co-authored-by: Pino Toscano <[email protected]>
@ptoscano ptoscano deleted the rhsm_repository-initial-tests branch June 24, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new_plugin New plugin tests tests unit tests/unit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants