Rundeck - fix TypeError on 404 api response #6983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
MehuiSeklayr
changed the title
felixfontein
added
check-before-release
changelogs/fragments/6983-rundeck-fix-typerrror-on-404-api-response.yml
Outdated
Show resolved
Hide resolved
…ponse.yml Co-authored-by: Felix Fontein <[email protected]>
|
If nobody objects, I'll merge this by the end of this week. |
felixfontein
removed
the
check-before-release
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #7040 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jul 31, 2023
* fix TypeError on 404 api response * add changelog fragment * Update changelogs/fragments/6983-rundeck-fix-typerrror-on-404-api-response.yml Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Vincent CHARLES <[email protected]> Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit a942545)
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #7041 🤖 @patchback |
|
@MehuiSeklayr thanks for your contribution! |
patchback bot
pushed a commit
that referenced
this pull request
Jul 31, 2023
* fix TypeError on 404 api response * add changelog fragment * Update changelogs/fragments/6983-rundeck-fix-typerrror-on-404-api-response.yml Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Vincent CHARLES <[email protected]> Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit a942545)
felixfontein
pushed a commit
that referenced
this pull request
Jul 31, 2023
… api response (#7041) Rundeck - fix TypeError on 404 api response (#6983) * fix TypeError on 404 api response * add changelog fragment * Update changelogs/fragments/6983-rundeck-fix-typerrror-on-404-api-response.yml Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Vincent CHARLES <[email protected]> Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit a942545) Co-authored-by: Vincent CHARLES <[email protected]>
felixfontein
pushed a commit
that referenced
this pull request
Jul 31, 2023
… api response (#7040) Rundeck - fix TypeError on 404 api response (#6983) * fix TypeError on 404 api response * add changelog fragment * Update changelogs/fragments/6983-rundeck-fix-typerrror-on-404-api-response.yml Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Vincent CHARLES <[email protected]> Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit a942545) Co-authored-by: Vincent CHARLES <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello dear Ansible community :)
This is my first contribution, feel free to express any kind of criticism, be it on the content or the format.
SUMMARY
I found a bug when using
community.general.rundeck_acl_policy.While creating a new ACL, I was greeted by the following trace:
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
On success, the
fetch_urlfunction returns something like:<addinfourl at 139713744344848 whose fp = <socket._fileobject object at 0x7f11a69761d0>>However, when the api returns a 404, the return value is:
HTTP Error 404: Not FoundIn such a case,
response.read()fails with the aforementionned TypeError.The error could be specific to sundeck's API version. I did my testing with api version 40, which is not too far behind latest (v45), and way ahead of the current depreciation threshold (v14). source
Let me know if I am missing anything!
Have a great day :)