Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure pritunl validate_certs is honoured in all methods #7156

Merged
merged 4 commits into from
Sep 6, 2023
Merged

Ensure pritunl validate_certs is honoured in all methods #7156

merged 4 commits into from
Sep 6, 2023

Conversation

dsmackie
Copy link
Contributor

SUMMARY

Update Pritunl API to honour validate_certs parameter.

Fixed #7155 7155

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

community.general.pritunl_org

ADDITIONAL INFORMATION

BEFORE

TASK [pritunl-server-ubuntu : Install Pritunl | Create Organisation]
fatal: [server01-vm_8aac]: FAILED! => {"ansible_facts": {"discovered_interpreter_python": "/usr/bin/python3"}, "changed": false, "msg": "<urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: self signed certificate (_ssl.c:1131)>"}

AFTER

TASK [pritunl-server-ubuntu : Install Pritunl | Create Organisation]
ok: [server01-vm_8aac]

@ansibullbot
Copy link
Collaborator

cc @Lowess
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug module_utils module_utils net_tools new_contributor Help guide this first time contributor plugins plugin (any type) labels Aug 27, 2023
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-6 labels Aug 27, 2023
felixfontein
felixfontein reviewed Aug 27, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Can you please add a changelog fragment? Thanks.

@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot ansibullbot added ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Aug 27, 2023
@ansibullbot ansibullbot removed ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Aug 27, 2023
felixfontein
felixfontein approved these changes Sep 3, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge in a few days if nobody objects.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Sep 6, 2023
@felixfontein felixfontein merged commit 0862511 into ansible-collections:main Sep 6, 2023
@patchback
Copy link

patchback bot commented Sep 6, 2023 •
edited
Loading

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/0862511e82ddf828aa223a673e2b3c840ca65676/pr-7156

Backported as #7215

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@dsmackie thanks for this contribution as well!

patchback bot pushed a commit that referenced this pull request Sep 6, 2023
@dsmackie @patchback
Ensure pritunl validate_certs is honoured in all methods (#7156)
6f7c3d8 
* Ensure pritunl validate_certs is honoured in all methods

* Create changelog fragment

* Rename 7156-ensure-validate-certs-parameter-is-honoured to 7156-ensure-validate-certs-parameter-is-honoured.yml

* Update changelog fragment.

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 0862511)
@patchback patchback bot mentioned this pull request Sep 6, 2023
Merged
@patchback
Copy link

patchback bot commented Sep 6, 2023 •
edited
Loading

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/0862511e82ddf828aa223a673e2b3c840ca65676/pr-7156

Backported as #7216

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 6, 2023
@dsmackie @patchback
Ensure pritunl validate_certs is honoured in all methods (#7156)
530e871 
* Ensure pritunl validate_certs is honoured in all methods

* Create changelog fragment

* Rename 7156-ensure-validate-certs-parameter-is-honoured to 7156-ensure-validate-certs-parameter-is-honoured.yml

* Update changelog fragment.

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 0862511)
@patchback patchback bot mentioned this pull request Sep 6, 2023
Merged
felixfontein pushed a commit that referenced this pull request Sep 6, 2023
@patchback @dsmackie
[PR #7156/0862511e backport][stable-6] Ensure pritunl validate_certs …
f4ccef4 
…is honoured in all methods (#7215)

Ensure pritunl validate_certs is honoured in all methods (#7156)

* Ensure pritunl validate_certs is honoured in all methods

* Create changelog fragment

* Rename 7156-ensure-validate-certs-parameter-is-honoured to 7156-ensure-validate-certs-parameter-is-honoured.yml

* Update changelog fragment.

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 0862511)

Co-authored-by: dsmackie <[email protected]>
felixfontein pushed a commit that referenced this pull request Sep 6, 2023
@patchback @dsmackie
[PR #7156/0862511e backport][stable-7] Ensure pritunl validate_certs …
94a350e 
…is honoured in all methods (#7216)

Ensure pritunl validate_certs is honoured in all methods (#7156)

* Ensure pritunl validate_certs is honoured in all methods

* Create changelog fragment

* Rename 7156-ensure-validate-certs-parameter-is-honoured to 7156-ensure-validate-certs-parameter-is-honoured.yml

* Update changelog fragment.

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 0862511)

Co-authored-by: dsmackie <[email protected]>
etrombly pushed a commit to etrombly/community.general that referenced this pull request Oct 25, 2023
@dsmackie @felixfontein
Ensure pritunl validate_certs is honoured in all methods (ansible-col…
eb01de1 
…lections#7156)

* Ensure pritunl validate_certs is honoured in all methods

* Create changelog fragment

* Rename 7156-ensure-validate-certs-parameter-is-honoured to 7156-ensure-validate-certs-parameter-is-honoured.yml

* Update changelog fragment.

---------

Co-authored-by: Felix Fontein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug module_utils module_utils net_tools new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Various Pritunl API methods do not honour validate_certs
3 participants
@dsmackie @ansibullbot @felixfontein