Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update incorrect path for pritunl organization post #7161

Merged
merged 3 commits into from
Sep 6, 2023
Merged

Update incorrect path for pritunl organization post #7161

merged 3 commits into from
Sep 6, 2023

Conversation

dsmackie
Copy link
Contributor

SUMMARY

Fix Pritunl API incorrect URL parameters.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

community.general.pritunl_org

ADDITIONAL INFORMATION

BEFORE

TASK [pritunl-server-ubuntu : Install Pritunl | Create Organisation]
fatal: [server01-vm_8aac]: FAILED! => {
    "ansible_facts": {
        "discovered_interpreter_python": "/usr/bin/python3"
    },
    "changed": false,
    "invocation": {
        "module_args": {
            "force": false,
            "name": "orgName",
            "pritunl_api_secret": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "pritunl_api_token": "HIDDEN",
            "pritunl_url": "https://HIDDEN",
            "state": "present",
            "validate_certs": false
        }
    },
    "msg": "HTTP Error 307: Temporary Redirect"
}

AFTER

TASK [pritunl-server-ubuntu : Install Pritunl | Create Organisation]
ok: [server01-vm_8aac]

@dsmackie dsmackie marked this pull request as ready for review August 27, 2023 23:50
@ansibullbot
Copy link
Collaborator

cc @Lowess
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug module_utils module_utils net_tools new_contributor Help guide this first time contributor plugins plugin (any type) labels Aug 27, 2023
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-6 labels Aug 28, 2023
felixfontein
felixfontein reviewed Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

felixfontein
felixfontein approved these changes Sep 3, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge in a few days if nobody objects.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Sep 6, 2023
@felixfontein felixfontein merged commit a23cd6c into ansible-collections:main Sep 6, 2023
@patchback
Copy link

patchback bot commented Sep 6, 2023 •
edited
Loading

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/a23cd6c1d5260c1fb2b2228d5f87bc42a0140fae/pr-7161

Backported as #7213

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@dsmackie thanks for your contribution!

patchback bot pushed a commit that referenced this pull request Sep 6, 2023
@dsmackie @patchback
Update incorrect path for pritunl organization post (#7161)
a9386e1 
* Update incorrect path for organization post

* Create changelog fragment

* Update changelog fragment.

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit a23cd6c)
@patchback patchback bot mentioned this pull request Sep 6, 2023
Merged
@patchback
Copy link

patchback bot commented Sep 6, 2023 •
edited
Loading

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/a23cd6c1d5260c1fb2b2228d5f87bc42a0140fae/pr-7161

Backported as #7214

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 6, 2023
@dsmackie @patchback
Update incorrect path for pritunl organization post (#7161)
d899fb4 
* Update incorrect path for organization post

* Create changelog fragment

* Update changelog fragment.

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit a23cd6c)
@patchback patchback bot mentioned this pull request Sep 6, 2023
Merged
felixfontein pushed a commit that referenced this pull request Sep 6, 2023
@patchback @dsmackie
[PR #7161/a23cd6c1 backport][stable-7] Update incorrect path for prit…
b6ed678 
…unl organization post (#7214)

Update incorrect path for pritunl organization post (#7161)

* Update incorrect path for organization post

* Create changelog fragment

* Update changelog fragment.

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit a23cd6c)

Co-authored-by: dsmackie <[email protected]>
felixfontein pushed a commit that referenced this pull request Sep 6, 2023
@patchback @dsmackie
[PR #7161/a23cd6c1 backport][stable-6] Update incorrect path for prit…
830e398 
…unl organization post (#7213)

Update incorrect path for pritunl organization post (#7161)

* Update incorrect path for organization post

* Create changelog fragment

* Update changelog fragment.

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit a23cd6c)

Co-authored-by: dsmackie <[email protected]>
etrombly pushed a commit to etrombly/community.general that referenced this pull request Oct 25, 2023
@dsmackie @felixfontein
Update incorrect path for pritunl organization post (ansible-collecti…
21f2969 
…ons#7161)

* Update incorrect path for organization post

* Create changelog fragment

* Update changelog fragment.

---------

Co-authored-by: Felix Fontein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug module_utils module_utils net_tools new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsmackie @ansibullbot @felixfontein