Fixing incorrect string encapsulation for -backend-config. #7301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
felixfontein
added
check-before-release
There was a problem hiding this comment.
Thanks for your contribution! Can you pleaes add a changelog fragment? Thanks.
- "terraform module - prevents `-backend-config` option double encapsulating with `shlex_quote` function. (ansible-collections#7301)."
changelogs/fragments/7301-fix-backend-config-string-encapsulation.yml
Outdated
Show resolved
Hide resolved
…ion.yml Co-authored-by: Felix Fontein <[email protected]>
felixfontein
approved these changes
Sep 24, 2023
felixfontein
removed
the
check-before-release
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #7314 🤖 @patchback |
|
@kosalaat thanks for your contribution! |
patchback bot
pushed a commit
that referenced
this pull request
Sep 24, 2023
* Fixing incorrect string encapsulation for -backend-config. Removing shlex_quote. * Adding change log fragemnt for bugfix: - "terraform module - prevents `-backend-config` option double encapsulating with `shlex_quote` function. (#7301)." * Update changelogs/fragments/7301-fix-backend-config-string-encapsulation.yml Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 7bf24ee)
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #7315 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Sep 24, 2023
* Fixing incorrect string encapsulation for -backend-config. Removing shlex_quote. * Adding change log fragemnt for bugfix: - "terraform module - prevents `-backend-config` option double encapsulating with `shlex_quote` function. (#7301)." * Update changelogs/fragments/7301-fix-backend-config-string-encapsulation.yml Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 7bf24ee)
This was referenced Sep 24, 2023
Closed
felixfontein
pushed a commit
that referenced
this pull request
Sep 25, 2023
…ulation for -backend-config. (#7314) Fixing incorrect string encapsulation for -backend-config. (#7301) * Fixing incorrect string encapsulation for -backend-config. Removing shlex_quote. * Adding change log fragemnt for bugfix: - "terraform module - prevents `-backend-config` option double encapsulating with `shlex_quote` function. (#7301)." * Update changelogs/fragments/7301-fix-backend-config-string-encapsulation.yml Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 7bf24ee) Co-authored-by: Kosala Atapattu <[email protected]>
felixfontein
pushed a commit
that referenced
this pull request
Sep 25, 2023
…ulation for -backend-config. (#7315) Fixing incorrect string encapsulation for -backend-config. (#7301) * Fixing incorrect string encapsulation for -backend-config. Removing shlex_quote. * Adding change log fragemnt for bugfix: - "terraform module - prevents `-backend-config` option double encapsulating with `shlex_quote` function. (#7301)." * Update changelogs/fragments/7301-fix-backend-config-string-encapsulation.yml Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 7bf24ee) Co-authored-by: Kosala Atapattu <[email protected]>
etrombly
pushed a commit
to etrombly/community.general
that referenced
this pull request
Oct 25, 2023
…collections#7301) * Fixing incorrect string encapsulation for -backend-config. Removing shlex_quote. * Adding change log fragemnt for bugfix: - "terraform module - prevents `-backend-config` option double encapsulating with `shlex_quote` function. (ansible-collections#7301)." * Update changelogs/fragments/7301-fix-backend-config-string-encapsulation.yml Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing shlex_quote.
SUMMARY
This FIX solves the following issues:
Terraform Azure backend configuration fails when client_secret contains special characters #5016
community.general.terraform unable to use postgres backend with sslmode=disable option #6517
ISSUE TYPE
COMPONENT NAME
terraform
ADDITIONAL INFORMATION
Removed the
shlex_quotefrom the backend-config command line argument.