Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR #7199/6b00b76f backport][stable-8] feat(gitlab_runner module): Add support for the new runner creation workflow #7511

Merged
merged 1 commit into from
Nov 13, 2023
Merged

[PR #7199/6b00b76f backport][stable-8] feat(gitlab_runner module): Add support for the new runner creation workflow #7511

merged 1 commit into from
Nov 13, 2023

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Nov 11, 2023

This is a backport of PR #7199 as merged into main (6b00b76).

SUMMARY

This PR adds support for the new GitLab Runner creation workflow.

See docs here : https://docs.gitlab.com/ee/ci/runners/new_creation_workflow.html

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

gitlab_runner module

ADDITIONAL INFORMATION

In GitLab's new API endpoint, active option is not supported any more (deprecated since 14.8, latest version is 16.4), and replaced with paused.

Both options are here handled (mutually exclusive) to keep backward compatibility. Another PR will be necessary to deprecate active option following GitLab evolution.

Fixes #3742

NB : This PR will keep Draft status until python-gitlab next release including the new API endpoint.

@lgatellier @patchback
feat(gitlab_runner module): Add support for the new runner creation w…
6350006 
…orkflow (#7199)

feat(gitlab_runner module): Handle new runner creation workflow

(cherry picked from commit 6b00b76)
@patchback patchback bot mentioned this pull request Nov 11, 2023
Merged
@felixfontein felixfontein marked this pull request as draft November 11, 2023 11:13
@ansibullbot
Copy link
Collaborator

cc @Lunik @SamyCoenen @Shaps @lgatellier @marwatk @metanovii @nejch @scodeman @sh0shin @suukit @waheedi @zanssa
click here for bot help

@ansibullbot ansibullbot added WIP Work in progress backport feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor plugins plugin (any type) labels Nov 11, 2023
@felixfontein
Copy link
Collaborator

Marking as draft so this won't get merged until the last 8.0.x bugfix release is out.

@felixfontein
Copy link
Collaborator

recheck

@felixfontein felixfontein marked this pull request as ready for review November 13, 2023 19:21
@felixfontein felixfontein merged commit 1a5ad80 into stable-8 Nov 13, 2023
@felixfontein felixfontein deleted the patchback/backports/stable-8/6b00b76f32b93982bceb2dba06ebe8438d6ed9af/pr-7199 branch November 13, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor plugins plugin (any type) WIP Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ansibullbot @felixfontein @lgatellier