Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pacemaker_cluster: implement check mode #8081

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

The module claims to support check mode, but in fact it does not care about module.check_mode.

Fixes #8062.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

pacemaker_cluster

@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-6 backport-8 Automatically create a backport for the stable-8 branch labels Mar 10, 2024
@ansibullbot
Copy link
Collaborator

cc @matbu
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug module module plugins plugin (any type) labels Mar 10, 2024
Co-authored-by: Mario Lenz <[email protected]>
Copy link
Contributor

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixfontein felixfontein merged commit 17e275b into ansible-collections:main Mar 14, 2024
121 checks passed
Copy link

patchback bot commented Mar 14, 2024

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/17e275bc0b830e40777df0a8b13146bd110fd8db/pr-8081

Backported as #8093

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Mar 14, 2024
patchback bot pushed a commit that referenced this pull request Mar 14, 2024
* Implement check mode for pacemaker_cluster.

* Fix restart code.

Co-authored-by: Mario Lenz <[email protected]>

---------

Co-authored-by: Mario Lenz <[email protected]>
(cherry picked from commit 17e275b)
Copy link

patchback bot commented Mar 14, 2024

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/17e275bc0b830e40777df0a8b13146bd110fd8db/pr-8081

Backported as #8094

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein deleted the check branch March 14, 2024 21:11
patchback bot pushed a commit that referenced this pull request Mar 14, 2024
* Implement check mode for pacemaker_cluster.

* Fix restart code.

Co-authored-by: Mario Lenz <[email protected]>

---------

Co-authored-by: Mario Lenz <[email protected]>
(cherry picked from commit 17e275b)
Copy link

patchback bot commented Mar 14, 2024

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/17e275bc0b830e40777df0a8b13146bd110fd8db/pr-8081

Backported as #8095

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator Author

@mariolenz thanks a lot for reviewing this!

patchback bot pushed a commit that referenced this pull request Mar 14, 2024
* Implement check mode for pacemaker_cluster.

* Fix restart code.

Co-authored-by: Mario Lenz <[email protected]>

---------

Co-authored-by: Mario Lenz <[email protected]>
(cherry picked from commit 17e275b)
felixfontein added a commit that referenced this pull request Mar 14, 2024
…heck mode (#8095)

pacemaker_cluster: implement check mode (#8081)

* Implement check mode for pacemaker_cluster.

* Fix restart code.

Co-authored-by: Mario Lenz <[email protected]>

---------

Co-authored-by: Mario Lenz <[email protected]>
(cherry picked from commit 17e275b)

Co-authored-by: Felix Fontein <[email protected]>
felixfontein added a commit that referenced this pull request Mar 14, 2024
…heck mode (#8094)

pacemaker_cluster: implement check mode (#8081)

* Implement check mode for pacemaker_cluster.

* Fix restart code.

Co-authored-by: Mario Lenz <[email protected]>

---------

Co-authored-by: Mario Lenz <[email protected]>
(cherry picked from commit 17e275b)

Co-authored-by: Felix Fontein <[email protected]>
felixfontein added a commit that referenced this pull request Mar 14, 2024
…heck mode (#8093)

pacemaker_cluster: implement check mode (#8081)

* Implement check mode for pacemaker_cluster.

* Fix restart code.

Co-authored-by: Mario Lenz <[email protected]>

---------

Co-authored-by: Mario Lenz <[email protected]>
(cherry picked from commit 17e275b)

Co-authored-by: Felix Fontein <[email protected]>
Massl123 pushed a commit to Massl123/community.general that referenced this pull request Feb 7, 2025
* Implement check mode for pacemaker_cluster.

* Fix restart code.

Co-authored-by: Mario Lenz <[email protected]>

---------

Co-authored-by: Mario Lenz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8 Automatically create a backport for the stable-8 branch bug This issue/PR relates to a bug module module plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

check_mode of community.general.pacemaker_cluster module
3 participants