-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pacemaker_cluster: implement check mode #8081
Conversation
Co-authored-by: Mario Lenz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #8093 🤖 @patchback |
* Implement check mode for pacemaker_cluster. * Fix restart code. Co-authored-by: Mario Lenz <[email protected]> --------- Co-authored-by: Mario Lenz <[email protected]> (cherry picked from commit 17e275b)
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #8094 🤖 @patchback |
* Implement check mode for pacemaker_cluster. * Fix restart code. Co-authored-by: Mario Lenz <[email protected]> --------- Co-authored-by: Mario Lenz <[email protected]> (cherry picked from commit 17e275b)
Backport to stable-8: 💚 backport PR created✅ Backport PR branch: Backported as #8095 🤖 @patchback |
@mariolenz thanks a lot for reviewing this! |
* Implement check mode for pacemaker_cluster. * Fix restart code. Co-authored-by: Mario Lenz <[email protected]> --------- Co-authored-by: Mario Lenz <[email protected]> (cherry picked from commit 17e275b)
…heck mode (#8095) pacemaker_cluster: implement check mode (#8081) * Implement check mode for pacemaker_cluster. * Fix restart code. Co-authored-by: Mario Lenz <[email protected]> --------- Co-authored-by: Mario Lenz <[email protected]> (cherry picked from commit 17e275b) Co-authored-by: Felix Fontein <[email protected]>
…heck mode (#8094) pacemaker_cluster: implement check mode (#8081) * Implement check mode for pacemaker_cluster. * Fix restart code. Co-authored-by: Mario Lenz <[email protected]> --------- Co-authored-by: Mario Lenz <[email protected]> (cherry picked from commit 17e275b) Co-authored-by: Felix Fontein <[email protected]>
…heck mode (#8093) pacemaker_cluster: implement check mode (#8081) * Implement check mode for pacemaker_cluster. * Fix restart code. Co-authored-by: Mario Lenz <[email protected]> --------- Co-authored-by: Mario Lenz <[email protected]> (cherry picked from commit 17e275b) Co-authored-by: Felix Fontein <[email protected]>
* Implement check mode for pacemaker_cluster. * Fix restart code. Co-authored-by: Mario Lenz <[email protected]> --------- Co-authored-by: Mario Lenz <[email protected]>
SUMMARY
The module claims to support check mode, but in fact it does not care about
module.check_mode
.Fixes #8062.
ISSUE TYPE
COMPONENT NAME
pacemaker_cluster