Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

make has_plugin detection method more reliable #362

Merged
merged 6 commits into from
Feb 16, 2021
Merged

make has_plugin detection method more reliable #362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c59db19
fix has_plugin detection method
joschi36 Feb 4, 2021
a48ef03
use even better method :)
joschi36 Feb 4, 2021
ccb20fd
add changelog fragment
joschi36 Feb 4, 2021
430e580
fix forgotten file extension
joschi36 Feb 4, 2021
efe6fff
Double Backticks ;)
joschi36 Feb 14, 2021
72b7772
Add PR link to changelog
gravesm Feb 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/362-helm-has_plugin-fix.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
bugfixes:
- helm - make helm-diff plugin detection more reliable by splitting by any whitespace instead of explicit whitespace (``\s``) (https://github.com/ansible-collections/community.kubernetes/pull/362).
2 changes: 1 addition & 1 deletion plugins/modules/helm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,7 @@ def has_plugin(command, plugin):
for line in out.splitlines():
if line.startswith("NAME"):
continue
name, _rest = line.split("\t", 1)
name, _rest = line.split(None, 1)
if name == plugin:
return True
return False
Expand Down