trying page_size patch #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dericcrago
force-pushed
the
testing_page_size
branch
3 times, most recently
from
c7ab943 to
ab35c55
Compare
|
This is quite a hack, I would avoid merging that as it can cause random problems when the galaxy-related code in Ansible is modified. Since it's limited to CI I guess you have to decide for yourself whether it's worth the trouble :) |
dericcrago
force-pushed
the
testing_page_size
branch
2 times, most recently
from
828560d to
df3771d
Compare
dericcrago
force-pushed
the
testing_page_size
branch
from
df3771d to
d89d5e3
Compare
|
The way the patch is organized now is much better, this way it will either be applied completely, or not at all. That should also decrease the probability that it randomly breaks at some point :) |
|
thanks for the comments @felixfontein ! |
patchback bot
pushed a commit
that referenced
this pull request
Apr 9, 2021
(cherry picked from commit 33c2eb7)
dericcrago
added a commit
that referenced
this pull request
Apr 9, 2021
(cherry picked from commit 33c2eb7) Co-authored-by: Deric Crago <[email protected]>
dericcrago
added a commit
that referenced
this pull request
Apr 9, 2021
(cherry picked from commit 33c2eb7)
dericcrago
added a commit
that referenced
this pull request
Apr 9, 2021
(cherry picked from commit 33c2eb7) Co-authored-by: Deric Crago <[email protected]>
This was referenced Apr 12, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
testing page_size patch as an alternative to git cloning
COMPONENT NAME
ADDITIONAL INFO
difffrom ansible/ansible#74191 (comment)