Fix date removal in nonverbose config (#262)

* Fix date removal in nonverbose config As in newer versions of RouterOS the date format is 2024-10-02 and no longer 2024/10/02, the regex did no longer match all cases. This is fixed. * Add changelog fragment
ansible-collections · Feb 20, 2024 · 232a013 · 232a013
1 parent 10fbc56
commit 232a013
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/changelogs/fragments/262-fix-date-removal.yml b/changelogs/fragments/262-fix-date-removal.yml
@@ -0,0 +1,2 @@
+bugfixes:
+  - facts - fix date not getting removed for idempotent config export (https://github.com/ansible-collections/community.routeros/pull/262).
diff --git a/plugins/modules/facts.py b/plugins/modules/facts.py
@@ -311,7 +311,7 @@ class Config(FactsBase):
         '/export',
     ]
 
-    RM_DATE_RE = re.compile(r'^# [a-z0-9/][a-z0-9/]* [0-9:]* by RouterOS')
+    RM_DATE_RE = re.compile(r'^# [a-z0-9/-][a-z0-9/-]* [0-9:]* by RouterOS')
 
     def populate(self):
         super(Config, self).populate()
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		bugfixes:
		- facts - fix date not getting removed for idempotent config export (https://github.com/ansible-collections/community.routeros/pull/262).