-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: improve split handling #47
Conversation
Codecov Report
@@ Coverage Diff @@
## main #47 +/- ##
==========================================
- Coverage 80.26% 80.13% -0.14%
==========================================
Files 11 11
Lines 1221 1223 +2
Branches 162 161 -1
==========================================
Hits 980 980
- Misses 183 184 +1
- Partials 58 59 +1
Continue to review full report at Codecov.
|
Will do a review this days sorry for delay |
Testing look ok, lets pull this PR, |
@felixfontein If we don't have anything else here can I merge (or you can do that)? |
@NikolayDachev feel free to press the button :) I can also press it, but I'm currently too busy with too many things... Merging this requires that #45 needs to be rebased, since there are conflicts. @akimrx it's probably easier if you squash your commits first, otherwise you have to resolve conflicts multiple times during rebasing. |
@NikolayDachev thanks for reviewing and merging! |
SUMMARY
While reviewing #45 I noticed that there are two
split()
calls which need a split limit.I rewrote the one handling
WHERE
to work better with #45 (namely first do the splitting, then search for the tokenWHERE
in the splitted list to avoid finding aWHERE
in a quoted string), and added a limit to the other.ISSUE TYPE
COMPONENT NAME
api