Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: improve split handling #47

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

While reviewing #45 I noticed that there are two split() calls which need a split limit.

I rewrote the one handling WHERE to work better with #45 (namely first do the splitting, then search for the token WHERE in the splitted list to avoid finding a WHERE in a quoted string), and added a limit to the other.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

api

@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #47 (c1b9aa2) into main (a88f4c8) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
- Coverage   80.26%   80.13%   -0.14%     
==========================================
  Files          11       11              
  Lines        1221     1223       +2     
  Branches      162      161       -1     
==========================================
  Hits          980      980              
- Misses        183      184       +1     
- Partials       58       59       +1     
Impacted Files Coverage Δ
plugins/modules/api.py 70.74% <100.00%> (-0.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a88f4c8...c1b9aa2. Read the comment docs.

@NikolayDachev
Copy link
Collaborator

Will do a review this days sorry for delay

@NikolayDachev
Copy link
Collaborator

Testing look ok, lets pull this PR,
As main fix can be considered handling WHERE
list_to_dic() change is ok as well however we should fix it as general

@NikolayDachev
Copy link
Collaborator

@felixfontein If we don't have anything else here can I merge (or you can do that)?

@felixfontein
Copy link
Collaborator Author

@NikolayDachev feel free to press the button :) I can also press it, but I'm currently too busy with too many things... Merging this requires that #45 needs to be rebased, since there are conflicts. @akimrx it's probably easier if you squash your commits first, otherwise you have to resolve conflicts multiple times during rebasing.

@NikolayDachev NikolayDachev merged commit 48c7920 into ansible-collections:main Sep 9, 2021
@felixfontein felixfontein deleted the api-split branch September 10, 2021 06:08
@felixfontein
Copy link
Collaborator Author

@NikolayDachev thanks for reviewing and merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants