Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use FQCN to M() references #291

Merged
merged 1 commit into from
Jul 14, 2020
Merged

Use FQCN to M() references #291

merged 1 commit into from
Jul 14, 2020

Conversation

bmillemathias
Copy link
Contributor

@bmillemathias bmillemathias commented Jul 12, 2020 •
edited by goneri
Loading

Depends-On: ansible/ansible-zuul-jobs#593

SUMMARY

ansible-collections/overview#89

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

Docs

Akasurde
Akasurde requested changes Jul 13, 2020
View reviewed changes
Copy link
Member

@Akasurde Akasurde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmillemathias Thanks for taking a look into this.

plugins/modules/vcenter_extension_facts.py Outdated Show resolved Hide resolved
plugins/modules/vcenter_extension_facts.py Outdated Show resolved Hide resolved
@bmillemathias
Copy link
Contributor Author

thanks for review @Akasurde

@goneri
Copy link
Member

goneri commented Jul 13, 2020

recheck

1 similar comment
@goneri
Copy link
Member

goneri commented Jul 13, 2020

recheck

@goneri goneri added the gate label Jul 14, 2020
@bmillemathias @Akasurde
Use FQCN to M() references
b8f1644 
Signed-off-by: Baptiste Mille-Mathias <[email protected]>
Co-authored-by: Abhijeet Kasurde <[email protected]>
@ansible-zuul ansible-zuul bot removed the gate label Jul 14, 2020
@Akasurde Akasurde self-requested a review July 14, 2020 04:54
@Akasurde Akasurde added the gate label Jul 14, 2020
@ansible-zuul ansible-zuul bot merged commit 8338f38 into ansible-collections:main Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akasurde Akasurde Awaiting requested review from Akasurde

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bmillemathias @goneri @Akasurde