Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix forwarder replicationscope none #260

Merged
merged 2 commits into from
Jun 19, 2021
Merged

fix forwarder replicationscope none #260

merged 2 commits into from
Jun 19, 2021

Conversation

BoldlyGoingNoWhre
Copy link
Contributor

SUMMARY

Fixes issue #259

plays with forwarders without replication are now idempotent & updatable.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_dns_zone

ADDITIONAL INFORMATION
Dropping parameter ReplicationScope from processing if it was already set to none for conditional forwarding dns zones.

jborean93
jborean93 approved these changes Jun 19, 2021
View reviewed changes
Copy link
Collaborator

@jborean93 jborean93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, I've pushed a commit which adds a changelog fragment just so others can see what has changed in the next community.windows release.

@jborean93 jborean93 merged commit 25804b7 into ansible-collections:main Jun 19, 2021
@jborean93 jborean93 mentioned this pull request Jun 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jborean93 jborean93 jborean93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BoldlyGoingNoWhre @jborean93 @Boldly-Going-Nowhere