win_xml: Hide warnings on element operation, unless debug or count is set #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Puts the element warnings in the debug flag, so they do not appear under normal circumstances.
Adds $count as a trigger for the message that includes the number of elements enumerated.
|
Honestly at this point I think the warnings should go. These are clearly more debug logging attempts and was probably used during development to get info back to the controller for debugging. We have a logging mechanism in the newer |
|
@jborean93 That's much easier then. I'll update this to just pull those lines. |
Removed the add-warning statements entirely, and the strings that were used in them.
|
Thanks for the PR @anthonylavado, I've pushed a commit which removed a stray |
|
Thanks for the fix up! If I come across anything else that I can fix in my travels, I'll send along a PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When running win_xml to add an element, it will display warnings in the output as it enumerates the multiple children in the element you've selected. This hides those behind the debug flag, as the warnings are simply displaying names of the element currently being looked at, and the count of total elements.
Fixes #205.
Partially addresses #210.
ISSUE TYPE
COMPONENT NAME
win_xml
ADDITIONAL INFORMATION
This is my first contribution here, please let me know if this needs improvement. Thanks!