-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update win_domain_user Module to Support SPN's & Kerberos Delegates #365
Conversation
It looks like CI is failing because of issues unrelated to my code. |
recheck |
The sanity has just been fixed but looks like Galaxy is having some problems that will hopefully get resolved soon. |
At a glance the changes look good, will need a changelog fragment to document the changes that have been added. Just for my understanding you are using this to create a domain account for use by a service with it's own SPN's and principals it can delegate to? I'll try to test out the changes either this week or next week. |
I'll get that fragment added ASAP! The use case you mentioned is fairly common and the modifications to this module would make that possible. Example: IIS AppPool Service Acct. -> MSSQL Service Acct. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, I've had to make some minor changes to get the tests running but everything else looks great.
SUMMARY
Updates the
win_domain_user
module to add support for SPN's (ServicePrincipalNames
) and Kerberos Delegates (PrinicpalsAllowedToDelegate
).ISSUE TYPE
COMPONENT NAME
win_domain_user
ADDITIONAL INFORMATION