Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lookup: return list even if single item found #117

Merged
merged 1 commit into from
Jun 4, 2021

Conversation

Akasurde
Copy link
Member

@Akasurde Akasurde commented Jun 1, 2021

SUMMARY

Always return list from k8s lookup plugin

Fixes: #9

Signed-off-by: Abhijeet Kasurde [email protected]

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

changelogs/fragments/9_lookup_k8s.yml
molecule/default/converge.yml
molecule/default/tasks/lookup_k8s.yml
plugins/lookup/k8s.py

@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #117 (92616c3) into main (eb4b85c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #117   +/-   ##
=======================================
  Coverage   24.02%   24.02%           
=======================================
  Files           1        1           
  Lines         154      154           
  Branches       29       29           
=======================================
  Hits           37       37           
- Misses        111      112    +1     
+ Partials        6        5    -1     
Impacted Files Coverage Δ
...ections/kubernetes/core/plugins/action/k8s_info.py 24.02% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb4b85c...92616c3. Read the comment docs.

@Akasurde Akasurde force-pushed the i9 branch 2 times, most recently from 54dfdf3 to f884639 Compare June 1, 2021 10:36
Always return list from k8s lookup plugin

Fixes: ansible-collections#9

Signed-off-by: Abhijeet Kasurde <[email protected]>
@Akasurde Akasurde merged commit cf0b71f into ansible-collections:main Jun 4, 2021
@Akasurde Akasurde deleted the i9 branch June 4, 2021 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

k8s lookup return a dictionary
3 participants