-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
molecule gc.yml - fix sporadic fail #144
Conversation
Codecov Report
@@ Coverage Diff @@
## main #144 +/- ##
=======================================
Coverage 24.02% 24.02%
=======================================
Files 1 1
Lines 154 154
Branches 29 29
=======================================
Hits 37 37
- Misses 111 112 +1
+ Partials 6 5 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the until
fix not work?
I guess no. Since it is not able to find |
indeed seems not enough, and we cannot add a wait condition for Job resource type as the API does not return information on Pods statuses. |
@abikouo Do you know any other predictive way by which we can remove the hardcoded sleep value? |
How about instead of waiting until the pod is running we first just wait until there is a pod. At that point we have the pod name and can easily just wait until the pod is running. Something like:
|
Make sense to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will be glad to have this fixed. 🎉
SUMMARY
Improve #132