Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k8s_cp turbo mode compliance #254

Merged
merged 4 commits into from
Feb 22, 2022
Merged

k8s_cp turbo mode compliance #254

merged 4 commits into from
Feb 22, 2022

Conversation

abikouo
Copy link
Contributor

@abikouo abikouo commented Oct 5, 2021

SUMMARY

closes #237

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@softwarefactory-project-zuul
Copy link

Build failed.

@softwarefactory-project-zuul
Copy link

Build succeeded.

gravesm
gravesm reviewed Feb 11, 2022
View reviewed changes
alinabuzachis
alinabuzachis reviewed Feb 11, 2022
View reviewed changes
Copy link
Contributor

@alinabuzachis alinabuzachis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I wrong or the check_mode logic is not handled here (even if the module has supports_check_mode=True)?

@abikouo
Copy link
Contributor Author

abikouo commented Feb 11, 2022

Am I wrong or the check_mode logic is not handled here (even if the module has supports_check_mode=True)?

check_mode is not supported by the module even if it states that, but this should be addressed in another PR
This PR is resolving turbo mode compliance only

@alinabuzachis
Copy link
Contributor

alinabuzachis commented Feb 11, 2022 •
edited
Loading

Am I wrong or the check_mode logic is not handled here (even if the module has supports_check_mode=True)?

check_mode is not supported by the module even if it states that, but this should be addressed in another PR This PR is resolving turbo mode compliance only

So, I was just wondering if it would be better to have it set to False if it's not supported. @gravesm

@gravesm
Copy link
Member

gravesm commented Feb 11, 2022

check_mode is not supported by the module even if it states that, but this should be addressed in another PR
This PR is resolving turbo mode compliance only

That's fine. Please, create an issue for it.

@softwarefactory-project-zuul
Copy link

Build failed.

@abikouo
Copy link
Contributor Author

abikouo commented Feb 14, 2022

recheck

@softwarefactory-project-zuul
Copy link

Build succeeded.

@abikouo
Copy link
Contributor Author

abikouo commented Feb 14, 2022

@alinabuzachis @gravesm the build succeeded and #380 has been created to track support for check_mode.
Please add your final review or comment if something is missing

gravesm
gravesm approved these changes Feb 17, 2022
View reviewed changes
Copy link
Member

@gravesm gravesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks!

@abikouo
Copy link
Contributor Author

abikouo commented Feb 17, 2022

regate

@abikouo abikouo added mergeit and removed mergeit labels Feb 17, 2022
@abikouo abikouo removed the request for review from alinabuzachis February 21, 2022 09:50
@abikouo
Copy link
Contributor Author

abikouo commented Feb 21, 2022

regate

@softwarefactory-project-zuul
Copy link

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

@abikouo
Copy link
Contributor Author

abikouo commented Feb 22, 2022

recheck

@softwarefactory-project-zuul
Copy link

Build succeeded.

@abikouo
Copy link
Contributor Author

abikouo commented Feb 22, 2022

regate

@softwarefactory-project-zuul
Copy link

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 44c8cff into ansible-collections:main Feb 22, 2022
gravesm added a commit to gravesm/kubernetes.core that referenced this pull request Jun 8, 2022
@gravesm
Backport ansible-collections#254 to refactored branch
41f73e4 
This ports commit 44c8cff to the refactored code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis left review comments

@gravesm gravesm gravesm approved these changes

Assignees
No one assigned
Labels
mergeit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

k8s_cp does not delay module load
3 participants
@abikouo @alinabuzachis @gravesm