generated from ansible-collections/collection_template
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate inventory plugin #582
Merged
softwarefactory-project-zuul
merged 4 commits into
ansible-collections:main
from
alinabuzachis:deprecate_inventory_plugin
Feb 16, 2023
Merged
Deprecate inventory plugin #582
softwarefactory-project-zuul
merged 4 commits into
ansible-collections:main
from
alinabuzachis:deprecate_inventory_plugin
Feb 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alina Buzachis <[email protected]>
6e4eb98
to
0eef91d
Compare
Signed-off-by: Alina Buzachis <[email protected]>
0eef91d
to
5f9490c
Compare
16e450a
to
063d372
Compare
Signed-off-by: Alina Buzachis <[email protected]>
063d372
to
e94094a
Compare
gravesm
reviewed
Feb 6, 2023
plugins/inventory/k8s.py
Outdated
why: | | ||
As discussed in U(https://github.com/ansible-collections/kubernetes.core/issues/31), we decided to | ||
remove the k8s inventory plugin in release 4.0.0. | ||
alternative: "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
alternative: "" | |
alternative: "Use M(kubernetes.core.k8s_info) and M(ansible.builtin.add_host) instead." |
Signed-off-by: Alina Buzachis <[email protected]>
gravesm
approved these changes
Feb 7, 2023
abikouo
approved these changes
Feb 13, 2023
regate |
regate |
regate |
regate |
regate |
regate |
This is the first step of #570. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Deprecate inventory plugin
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION