Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: handle multiline output #64

Merged
merged 1 commit into from
Apr 20, 2021
Merged

Conversation

Akasurde
Copy link
Member

@Akasurde Akasurde commented Apr 16, 2021

SUMMARY

Fixes: #11

Signed-off-by: Abhijeet Kasurde [email protected]

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

changelogs/fragments/399-helm_multiline.yml
molecule/default/roles/helm/tasks/tests_helm_plugin.yml
plugins/module_utils/helm.py
plugins/modules/helm.py
plugins/modules/helm_plugin.py
plugins/modules/helm_plugin_info.py

@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #64 (a8c7f74) into main (28223db) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #64   +/-   ##
=======================================
  Coverage   23.17%   23.17%           
=======================================
  Files           1        1           
  Lines         151      151           
  Branches       24       24           
=======================================
  Hits           35       35           
  Misses        111      111           
  Partials        5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28223db...a8c7f74. Read the comment docs.

@Akasurde Akasurde force-pushed the i399 branch 3 times, most recently from 9aaff51 to 69a744a Compare April 16, 2021 14:11
Copy link
Contributor

@alinabuzachis alinabuzachis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Akasurde Akasurde merged commit 5a0f5d6 into ansible-collections:main Apr 20, 2021
@Akasurde Akasurde deleted the i399 branch April 20, 2021 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

helm: has_plugin fails when helm is outputting multiline description
3 participants