Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHEL-08-020050 fails if loop list receives a single value #261

Closed
SeanathanVT opened this issue Mar 19, 2024 · 2 comments
Closed

RHEL-08-020050 fails if loop list receives a single value #261

SeanathanVT opened this issue Mar 19, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@SeanathanVT
Copy link

Describe the Issue
Logic for RHEL-08-020050 (specifically the “Update removal-action if exists” Task) fails if a single value is passed to the loop.

Expected Behavior
The task, and Role, should complete execution without issue.. Regardless of the number of items sent to the Task.

Actual Behavior
During execution, the loop was passed a single value (/etc/dconf/db/distro.d/20-authselect). A message is received stating the following:

Invalid data passed to ‘loop’, it requires a list, got this instead: /etc/dconf/db/distro.d/20-authselect. Hint: If you passed a list/dict of just one element, try adding wantlist=True to your lookup invocation or use q/query instead of lookup.

Control(s) Affected
RHEL-08-020050

Environment (please complete the following information):

  • branch being used: Final STIG V1R11 (released 2024-03-19)
  • Ansible Version: 2.15.3
  • Host Python Version: 3.11.5
  • Ansible Server Python Version: 3.11.5
  • Additional Details: N/A

Additional Notes
N/A

Possible Solution
As suggested in the failed task, “try adding wantlist=True to your lookup invocation or use q/query instead of lookup”.

@Phenix66
Copy link
Contributor

Posted a PR with a potential more straightforward fix. Shell returns both stdout and stdout_lines, so why not just use the one that is already a list?

@SeanathanVT
Copy link
Author

Posted a PR with a potential more straightforward fix. Shell returns both stdout and stdout_lines, so why not just use the one that is already a list?

@Phenix66 Thanks for handling that. I was swamped yesterday but was going to look more into it today -- you beat me to it!

Phenix66 added a commit to Phenix66/RHEL8-STIG that referenced this issue Mar 21, 2024
uk-bolly added a commit that referenced this issue Mar 21, 2024
Updated RHEL-08-020050 to loop over stdout_lines. Fixes issue #261.
@uk-bolly uk-bolly closed this as completed Apr 9, 2024
uk-bolly added a commit that referenced this issue Apr 30, 2024
* ruleid updates for v1r12 refer changelog

Signed-off-by: Mark Bolwell <[email protected]>

* updated

Signed-off-by: Mark Bolwell <[email protected]>

* updated PRELIM in title

Signed-off-by: Mark Bolwell <[email protected]>

* updated the workflow version and galaxy setup

Signed-off-by: Mark Bolwell <[email protected]>

* fix typo

Signed-off-by: Mark Bolwell <[email protected]>

* Oraclelinux updated thanks to @BillSkiCO

Signed-off-by: Mark Bolwell <[email protected]>

* updated task 20030 thanks to @BillSkiCO

Signed-off-by: Mark Bolwell <[email protected]>

* updated 40321 thanks to @whitehat237

Signed-off-by: Mark Bolwell <[email protected]>

* updated after feedback from #245

Signed-off-by: Mark Bolwell <[email protected]>

* added issue #248 fix

Signed-off-by: Mark Bolwell <[email protected]>

* Added fix for #254

Signed-off-by: Mark Bolwell <[email protected]>

* fix syntax

Signed-off-by: Mark Bolwell <[email protected]>

* Squashed commit of the following:

commit 14d7da6a3335dea85d73044cac45f851d45e721f
Author: Mark Bolwell <[email protected]>
Date:   Wed Feb 21 15:52:45 2024 +0000

    updated

    Signed-off-by: Mark Bolwell <[email protected]>

commit e6b8a7c2008da9cf11075265801723c597284d6e
Author: Mark Bolwell <[email protected]>
Date:   Wed Feb 21 15:52:05 2024 +0000

    lint and variable improvements

    Signed-off-by: Mark Bolwell <[email protected]>

commit 79948fb314df745bc37f94dffcdf6ec818d945bc
Author: Mark Bolwell <[email protected]>
Date:   Wed Feb 21 15:51:32 2024 +0000

    ssh validation added

    Signed-off-by: Mark Bolwell <[email protected]>

commit 4742d58286387ffdbf569c2094d34290c8f2f90a
Author: Mark Bolwell <[email protected]>
Date:   Wed Feb 21 15:50:46 2024 +0000

    ssh validation added

    Signed-off-by: Mark Bolwell <[email protected]>

commit 33348bc1d3a0537d0cdbcfc70c10286875d97261
Author: Mark Bolwell <[email protected]>
Date:   Wed Feb 21 15:50:25 2024 +0000

    changed ordering and added logic

    Signed-off-by: Mark Bolwell <[email protected]>

commit 6c2d07987d379575c6ecf766e528da19ba5ffae0
Author: Mark Bolwell <[email protected]>
Date:   Wed Feb 21 15:50:12 2024 +0000

    removed as mnot required

    Signed-off-by: Mark Bolwell <[email protected]>

commit 1d775c698c9270f707dddbd955d096bfaa978dae
Author: Mark Bolwell <[email protected]>
Date:   Wed Feb 21 15:50:04 2024 +0000

    updated

    Signed-off-by: Mark Bolwell <[email protected]>

commit 562d7604e5263ed4d5cd97cdd2a46ea4a1c3f58f
Author: Mark Bolwell <[email protected]>
Date:   Wed Feb 21 15:49:57 2024 +0000

    updated precommit

    Signed-off-by: Mark Bolwell <[email protected]>

commit bb46131304f00cfe9c9b7b62dda9150ab5d19643
Author: Mark Bolwell <[email protected]>
Date:   Wed Feb 21 12:04:15 2024 +0000

    Added ability for audit_only

    Signed-off-by: Mark Bolwell <[email protected]>

Signed-off-by: Mark Bolwell <[email protected]>

* fix typo line 020030

Signed-off-by: Mark Bolwell <[email protected]>

* updated due to galaxy_ng changes

Signed-off-by: Mark Bolwell <[email protected]>

* Revert "fixed gnutls as per issue 196 thansk to @jmalpede"

This reverts commit 63c4c84.

Signed-off-by: William Panlener <[email protected]>

* Update main.yml

Removing stale var rhel8stig_sshd_compression

Signed-off-by: William Golembieski <[email protected]>

* [pre-commit.ci] pre-commit autoupdate

updates:
- [github.com/pre-commit/pre-commit-hooks: v4.4.0 → v4.5.0](pre-commit/pre-commit-hooks@v4.4.0...v4.5.0)
- [github.com/gitleaks/gitleaks: v8.18.0 → v8.18.1](gitleaks/gitleaks@v8.18.0...v8.18.1)
- [github.com/ansible-community/ansible-lint: v6.20.2 → v6.22.1](ansible/ansible-lint@v6.20.2...v6.22.1)
- [github.com/adrienverge/yamllint.git: v1.32.0 → v1.33.0](https://github.com/adrienverge/yamllint.git/compare/v1.32.0...v1.33.0)

* [pre-commit.ci] pre-commit autoupdate

updates:
- [github.com/gitleaks/gitleaks: v8.18.1 → v8.18.2](gitleaks/gitleaks@v8.18.1...v8.18.2)
- [github.com/ansible-community/ansible-lint: v6.22.1 → v24.2.0](ansible/ansible-lint@v6.22.1...v24.2.0)
- [github.com/adrienverge/yamllint.git: v1.33.0 → v1.35.1](https://github.com/adrienverge/yamllint.git/compare/v1.33.0...v1.35.1)

* updated Readme credits

Signed-off-by: Mark Bolwell <[email protected]>

* updated credits

Signed-off-by: Mark Bolwell <[email protected]>

* [pre-commit.ci] pre-commit autoupdate

updates:
- [github.com/ansible-community/ansible-lint: v24.2.0 → v24.2.1](ansible/ansible-lint@v24.2.0...v24.2.1)

* Updated RHEL-08-020050 to loop over stdout_lines. Fixes issue #261.

Signed-off-by: Phenix66 <[email protected]>

* [pre-commit.ci] pre-commit autoupdate

updates:
- [github.com/pre-commit/pre-commit-hooks: v4.5.0 → v4.6.0](pre-commit/pre-commit-hooks@v4.5.0...v4.6.0)

* addressing #251

Signed-off-by: Mark Bolwell <[email protected]>

* fix issue #263

Signed-off-by: Mark Bolwell <[email protected]>

* Address issues #242

Signed-off-by: Mark Bolwell <[email protected]>

* housekeeping lint

Signed-off-by: Mark Bolwell <[email protected]>

* Meet fix text of V-244546

Signed-off-by: Eric Lehmann <[email protected]>

* issue #267

Signed-off-by: Mark Bolwell <[email protected]>

* [pre-commit.ci] pre-commit autoupdate

updates:
- [github.com/ansible-community/ansible-lint: v24.2.1 → v24.2.2](ansible/ansible-lint@v24.2.1...v24.2.2)

* fixed error in conditional rhel-08-020022

Signed-off-by: Mark Bolwell <[email protected]>

---------

Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: William Panlener <[email protected]>
Signed-off-by: William Golembieski <[email protected]>
Signed-off-by: uk-bolly <[email protected]>
Signed-off-by: Phenix66 <[email protected]>
Signed-off-by: Eric Lehmann <[email protected]>
Co-authored-by: William Panlener <[email protected]>
Co-authored-by: William Golembieski <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Phenix66 <[email protected]>
Co-authored-by: Eric Lehmann <[email protected]>
uk-bolly pushed a commit that referenced this issue May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants