Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

March updates #44

Merged
merged 4 commits into from
Mar 20, 2023
Merged

March updates #44

merged 4 commits into from
Mar 20, 2023

Conversation

uk-bolly
Copy link
Member

Overall Review of Changes:

updated yamllint
removed empty lines after lint
initial molecule added - thanks t @bbaassssiiee in rh8
galaxy workflow updated

How has this been tested?:
Manually

Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly uk-bolly requested a review from MrSteve81 March 20, 2023 15:19
@uk-bolly uk-bolly marked this pull request as ready for review March 20, 2023 15:29
@bbaassssiiee
Copy link
Member

You could use molecule instead of terraform to simplify CI...

@uk-bolly
Copy link
Member Author

You could use molecule instead of terraform to simplify CI...

Good shout, although we want to test all the bootloader options as well as a system reboot. We have alot of full OS systems being used by our clients so for a few minutes extra testing we have a greater peace of mind.

Copy link
Contributor

@MrSteve81 MrSteve81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@uk-bolly uk-bolly merged commit 7e0172a into devel Mar 20, 2023
@uk-bolly uk-bolly deleted the march_updates branch March 20, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants