Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reverse proxy_headers config, supersedes proxy_mode #187

Merged
merged 5 commits into from
Apr 17, 2024
Merged

Add reverse proxy_headers config, supersedes proxy_mode #187

merged 5 commits into from
Apr 17, 2024

Conversation

roumano
Copy link

@roumano roumano commented Apr 15, 2024

Permit parse reverse proxy headers
8e2f3eb 
- Via created a new optional variable : keycloak_quarkus_proxy_headers
- Fix enhancement ansible-middleware#183
- see https://www.keycloak.org/server/reverseproxy about the official documentation
guidograzioli
guidograzioli requested changes Apr 15, 2024
View reviewed changes
Copy link
Member

@guidograzioli guidograzioli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Please address the review comments. If you feel adventurous, there is a molecule test already testing the proxy setup using the former proxy configuration, that you are welcome to update using this parameter

roles/keycloak_quarkus/README.md Show resolved Hide resolved
roles/keycloak_quarkus/templates/keycloak.service.j2 Outdated Show resolved Hide resolved
@guidograzioli guidograzioli added deprecated_features Features that have been deprecated and are scheduled for removal in a future release minor_changes New parameters added to modules, or non-breaking behavior changes to existing parameters; no bugfix and removed deprecated_features Features that have been deprecated and are scheduled for removal in a future release labels Apr 15, 2024
guidograzioli
guidograzioli approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@guidograzioli guidograzioli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@roumano
Copy link
Author

roumano commented Apr 17, 2024

you welcome.

It's possible to release a new version (lastest is 2.1.0 done the 28 february), so it's can easily deploy on production server ?

@guidograzioli guidograzioli merged commit 4ba9014 into ansible-middleware:main Apr 17, 2024
18 checks passed
@guidograzioli guidograzioli changed the title Permit parse reverse proxy headers Add reverse proxy_headers config, supersedes proxy_mode Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guidograzioli guidograzioli guidograzioli approved these changes

Assignees
No one assigned
Labels
minor_changes New parameters added to modules, or non-breaking behavior changes to existing parameters; no bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roumano @guidograzioli