-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggest adt installation #662
Conversation
c8fcc72
to
b41445c
Compare
b41445c
to
22132ae
Compare
@audgirka This is not rendering correct, see https://ansible--662.org.readthedocs.build/projects/builder/en/662/installation/ correct the RST syntax. |
af6171d
to
56763f9
Compare
4738fe3
to
9b889de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thank you for your interest in ansible-builder.
We've looked over this proposed change, however we would like to see some of the wording changed.
Instead of recommending this as the preferred way to install ansible-builder, we believe it should be presented as just an additional option. The reasoning for the decision making as to why a user would want to use this installation option, that includes many more tools than just builder should be explained, and also indicated what audience may be best served by doing so. However, this should probably be a link to the ansible-dev-tools
repo or documentation, where that information can be explained in more detail.
Will look at the wording changes for the "recommended" approach. Line 20 onwards explains briefly the use case for We do have a link in place for |
9b889de
to
75a30a0
Compare
6703078
to
5100a5e
Compare
Let's update the wording per @sivel request so we can get this in. If it needs to be revised further in the futre we can do that at a later date. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some suggestions. Feel free to take them, leave them, or modify them however you think. Hope this helps!
8b21449
to
9db1228
Compare
9db1228
to
39c53a3
Compare
@sivel Please take another look, that should be the text we agreed on ("alternative"), renders ok, it has the note and no extra heading. You might want to retrigger the failed job, which fails for unrelated reason. I cannot do it myself. |
Co-authored-by: Don Naro <[email protected]>
Suggest ADT installation
Jira-https://issues.redhat.com/browse/AAP-19818