Tests failing with newer versions of pytest-plus: "has an id that does not match our safe pattern '^[\w_\-\.]+$' for use with a terminal"

[johanneskastl]

Newer versions of pytest-plus are complaining because the naming of the tests is not safe:

[   32s] ============================= test session starts ==============================
[   32s] platform linux -- Python 3.11.5, pytest-7.4.3, pluggy-1.3.0 -- /usr/bin/python3.11
[   32s] cachedir: .pytest_cache
[   32s] rootdir: /home/abuild/rpmbuild/BUILD/ansible-compat-4.1.10
[   32s] configfile: pyproject.toml
[   32s] testpaths: test
[   32s] plugins: mock-3.12.0, plus-0.0.0
[   32s] collecting ... ERROR: Failed run due to following issues being identified:
[   32s] Test <Function test__update_env_no_old_value_no_default[value1-a:b]> has an id that does not match our safe pattern '^[\w_\-\.]+$' for use with a terminal.
[   32s] Test <Function test__update_env_no_old_value_no_default[value2-a:b:c]> has an id that does not match our safe pattern '^[\w_\-\.]+$' for use with a terminal.
[   32s] Test <Function test__update_env_no_old_value[a:b-value0-c:a:b]> has an id that does not match our safe pattern '^[\w_\-\.]+$' for use with a terminal.
[   32s] Test <Function test__update_env_no_old_value[a:b-value1-c:d:a:b]> has an id that does not match our safe pattern '^[\w_\-\.]+$' for use with a terminal.
[   32s] Test <Function test__update_env_no_default[a:b-value0-c:a:b]> has an id that does not match our safe pattern '^[\w_\-\.]+$' for use with a terminal.
[   32s] Test <Function test__update_env_no_default[a:b-value1-c:d:a:b]> has an id that does not match our safe pattern '^[\w_\-\.]+$' for use with a terminal.
[   32s] Test <Function test__update_env[a--value1-e:a]> has an id that does not match our safe pattern '^[\w_\-\.]+$' for use with a terminal.
[   32s] Test <Function test__update_env[a-c-value3-e:f:a]> has an id that does not match our safe pattern '^[\w_\-\.]+$' for use with a terminal.
[   32s] 
[   32s] collected 93 items

I have not found a fix in the list of commits, did I just miss it or is there none yet?

Kind Regards,
Johannes

[sebix]

The check can be disabled with

PYTEST_CHECK_TEST_ID_REGEX=0

See https://github.com/pytest-dev/pytest-plus#user-content-avoiding-problematic-test-identifiers

[johanneskastl]

Thanks @sebix! I think the test names should finally be fixed upstream like in other ansible-related tools. But for now at least the openSUSE package is building again...