Adding initial project stucture #1
Conversation
ssbarnea
force-pushed
the
devel
branch
3 times, most recently
from
ec754a3 to
9d5e93c
Compare
|
Sorry, I haven't found time to post comments, I'll do so post-merge. I've seen a number of occurences of hardcoded mentions of other projects and unnecessary stuff. |
| Run the tests under {basepython} and | ||
| devel: ansible devel branch | ||
| ansible29: ansible 2.9 | ||
| core: ansible-base 2.10 |
| test | ||
| deps = | ||
| ansible29: ansible>=2.9,<2.10 | ||
| py: ansible-core>=2.11 |
| @@ -0,0 +1,13 @@ | |||
| #! /usr/bin/env python3 | |||
| """Ansible-lint distribution package setuptools installer. | |||
| [aliases] | ||
| dists = clean --all sdist bdist_wheel | ||
|
|
| Programming Language :: Python :: 3 | ||
| Programming Language :: Python :: 3.6 | ||
| Programming Language :: Python :: 3.7 | ||
| Programming Language :: Python :: 3.8 |
| Topic :: Utilities | ||
| keywords = | ||
| ansible | ||
| lint |
| [codespell] | ||
| skip = .tox,.mypy_cache,build,.git,.eggs,pip-wheel-metadata |
| profile = "black" | ||
|
|
||
| [tool.setuptools_scm] | ||
| local_scheme = "no-local-version" |
| ; warn_unused_configs = True | ||
| exclude = test/local-content | ||
|
|
||
| [mypy-pytest] |
There was a problem hiding this comment.
I think the recent pytest has typing embedded.
| @@ -0,0 +1,30 @@ | |||
| # | |||
There was a problem hiding this comment.
I think I'd prefer this in a separate requirements/ dir.
There was a problem hiding this comment.
I would like to hide many of the files from root under a subfolder but picking requirements/ would not be a generic enough approach. Lets delay this until we can make a more generic solution, maybe under .config/?
| - repo: local | ||
| hooks: | ||
| - id: immutable-setup-py | ||
| name: Verify that setup.py stays immutable | ||
| description: >- | ||
| This is a sanity check that makes sure that | ||
| the `setup.py` file isn't changed. | ||
| # Using Python here because using | ||
| # shell test does not seem to work in CIs: | ||
| entry: >- | ||
| sh -c 'git hash-object setup.py | ||
| | | ||
| python -c raise\ SystemExit\(input\(\)\ !=\ \"f6d1010b609cbe816d3ef652eee452d09d52979f\"\) | ||
| ' | ||
| pass_filenames: false | ||
| language: system | ||
| files: >- | ||
| ^setup\.py$ |
There was a problem hiding this comment.
I'm hearing pip now special-cases setuptools to support editable installs w/o setup.py. Somebody needs to evaluate how well that works and maybe just wipe this file.
| disable = | ||
| # On purpose disabled as we rely on black | ||
| line-too-long, | ||
| # TODO(ssbarnea): remove temporary skips adding during initial adoption: |
There was a problem hiding this comment.
Looks like most of this should be dropped since it's a new project and it's best not to allow weird stuff from the very beginning.
| exclude: > | ||
| (?x)^( | ||
| examples/playbooks/(with-skip-tag-id|unicode).yml| | ||
| examples/playbooks/example.yml | ||
| )$ |
| # - windows-latest | ||
| # - windows-2016 | ||
| include: | ||
| - tox_env: py36 |
There was a problem hiding this comment.
What's the point of having the toxenv for each interpreter if tox -e py picks up the current one already?
| matrix: | ||
| python-version: | ||
| # keep list sorted as it determines UI order too | ||
| - 3.6 |
There was a problem hiding this comment.
I usually sort by "importance". That is the latest, the lowest, maybe PyPy, and then the rest.
There was a problem hiding this comment.
Alphabetical for the moment
| - name: Build dists | ||
| run: python -m tox | ||
| - name: Publish to test.pypi.org | ||
| if: >- # "create" workflows run separately from "push" & "pull_request" |
There was a problem hiding this comment.
the comment doesn't match the content
No description provided.