address review changes

ansible · Sep 7, 2023 · 937513d · 937513d
1 parent 4871021
commit 937513d
Showing 1 changed file with 4 additions and 7 deletions.
diff --git a/src/ansiblelint/rules/no_jinja_when.py b/src/ansiblelint/rules/no_jinja_when.py
@@ -83,8 +83,7 @@ def transform(
                 if k == "roles" and isinstance(v, list):
                     transform_for_roles(v, key_to_check=key_to_check)
                 elif k in key_to_check:
-                    processed_value = re.sub(r"{{ (.*?) }}", r"\1", v)
-                    v = processed_value
+                    v = re.sub(r"{{ (.*?) }}", r"\1", v)
                 task[k] = v
             match.fixed = True
 
@@ -96,12 +95,10 @@ def transform_for_roles(v: list[Any], key_to_check: tuple[str, ...]) -> None:
             if new_key in key_to_check:
                 if isinstance(new_value, list):
                     for index, nested_value in enumerate(new_value):
-                        processed_value = re.sub(r"{{ (.*?) }}", r"\1", nested_value)
-                        new_value[index] = processed_value
-                        v[idx][new_key] = new_value
+                        new_value[index] = re.sub(r"{{ (.*?) }}", r"\1", nested_value)
+                    v[idx][new_key] = new_value
                 if isinstance(new_value, str):
-                    processed_value = re.sub(r"{{ (.*?) }}", r"\1", new_value)
-                    v[idx][new_key] = processed_value
+                    v[idx][new_key] = re.sub(r"{{ (.*?) }}", r"\1", new_value)
 
 
 if "pytest" in sys.modules: