Rename --write option to --fix #3748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
requested review from
a team,
cristianonicolai,
audgirka and
Ruchip16
ssbarnea
changed the title
This change will make ansible-lint auto-fixing feature in line with other tools that can perform similar transformations (ruff, black, ...). For compatibility, we automatically convert old option into new one and display a warning.
ssbarnea
force-pushed
the
fix/transform
branch
from
939be03 to
32c47ff
Compare
nrdufour
added a commit
to nrdufour/home-ops
that referenced
this pull request
Oct 3, 2023
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ansible-lint](https://github.com/ansible/ansible-lint) ([changelog](https://github.com/ansible/ansible-lint/releases)) | minor | `==6.19.0` -> `==6.20.0` | --- ### Release Notes <details> <summary>ansible/ansible-lint (ansible-lint)</summary> ### [`v6.20.0`](https://github.com/ansible/ansible-lint/releases/tag/v6.20.0) [Compare Source](ansible/ansible-lint@v6.19.0...v6.20.0) #### Minor Changes - Respect cgroup CPU limits when running inside containers ([#​3749](ansible/ansible-lint#3749)) [@​ssbarnea](https://github.com/ssbarnea) - Rename --write option to --fix ([#​3748](ansible/ansible-lint#3748)) [@​ssbarnea](https://github.com/ssbarnea) - Add auto-fixing implementation for `no-free-form` rule ([#​3725](ansible/ansible-lint#3725)) [@​ajinkyau](https://github.com/ajinkyau) - Add auto-fixing implementation for `partial-become` rule ([#​3692](ansible/ansible-lint#3692)) [@​shatakshiiii](https://github.com/shatakshiiii) - Add auto-fixing implementation for `no-jinja-when` rule ([#​3721](ansible/ansible-lint#3721)) [@​shatakshiiii](https://github.com/shatakshiiii) #### Bugfixes - Fix the detection of role vars missing role prefix ([#​3750](ansible/ansible-lint#3750)) [@​cavcrosby](https://github.com/cavcrosby) - Clarify auto-fix arguments use ([#​3751](ansible/ansible-lint#3751)) [@​ssbarnea](https://github.com/ssbarnea) - Avoid IndexError exception with jinja transform ([#​3747](ansible/ansible-lint#3747)) [@​ssbarnea](https://github.com/ssbarnea) - Fix docs typo ([#​3746](ansible/ansible-lint#3746)) [@​ssbarnea](https://github.com/ssbarnea) - Add /bin/bash executable to example correct code for pipefail rule ([#​3731](ansible/ansible-lint#3731)) [@​Perdu](https://github.com/Perdu) - Properly avoid `pipx` venv path to be included in altered path warning ([#​3730](ansible/ansible-lint#3730)) [@​chrysle](https://github.com/chrysle) - Fix transform exception with local_action with old syntax ([#​3743](ansible/ansible-lint#3743)) [@​ssbarnea](https://github.com/ssbarnea) - Support only_upgrade ([#​3734](ansible/ansible-lint#3734)) [@​soroshsabz](https://github.com/soroshsabz) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi45Ni4wIiwidXBkYXRlZEluVmVyIjoiMzYuOTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Reviewed-on: https://git.home/nrdufour/home-ops/pulls/97 Co-authored-by: Renovate <[email protected]> Co-committed-by: Renovate <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will make ansible-lint auto-fixing feature in line with other tools that can perform similar transformations (ruff, black, ...).
For compatibility, we automatically convert old option into new one and display a warning.
Fixes: #3742