Fix failing ansible-lint CI job
#4520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
audgirka
approved these changes
Feb 12, 2025
The "Packit-as-a-Service" CI jobs have been failing since commit 34eb179[^1] from 2024-04-04. From the log[^2] of a recent failed build[^3], I saw the following output: ```log 2025-01-23 17:15:27.261 commands.py DEBUG Command: python3 -m build --sdist --outdir dist ... 2025-01-23 17:15:30.617 logging.py INFO Successfully built ansible_lint-25.1.1.dev1.tar.gz 2025-01-23 17:15:30.634 commands.py DEBUG Command: sh -c ls dist/ansible-lint-*.tar.gz 2025-01-23 17:15:30.636 logging.py INFO ls: cannot access 'dist/ansible-lint-*.tar.gz': No such file or directory 2025-01-23 17:15:30.636 commands.py ERROR Command 'sh -c ls dist/ansible-lint-*.tar.gz' failed. ``` The problem is therefore that line 8 of `.packit.yaml`[^4] expects a file of the form `ansible-lint-*` when the file is _actually_ named `ansible_lint-*`. Changing the line should fix the build, or at the very least, this single error. [^1]: ansible@34eb179 [^2]: https://download.copr.fedorainfracloud.org/results/packit/ansible-ansible-lint-main/srpm-builds/08563847/builder-live.log.gz [^3]: https://copr.fedorainfracloud.org/coprs/packit/ansible-ansible-lint-main/build/8563847/ [^4]: https://github.com/ansible/ansible-lint/blob/395b674bbc78bc4d9da641c38a7e959b4993d9a4/.packit.yaml#L8
audgirka
force-pushed
the
fix-failing-ci
branch
from
906493f to
8b9f559
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Packit-as-a-Service" CI jobs have been failing since commit 34eb1791 from 2024-04-04. From the log2 of a recent failed build3, I saw the following output:
The problem is therefore that line 8 of
.packit.yaml4 expects a file of the formansible-lint-*when the file is actually namedansible_lint-*. Changing the line should fix the build, or at the very least, this single error.I'm unfortunately not sure how to test this change without making a PR and running CI. I hope it works!
Footnotes
https://github.com/ansible/ansible-lint/commit/34eb1794a1e2e69b51bde4d953e463f756fe70f5 ↩
https://download.copr.fedorainfracloud.org/results/packit/ansible-ansible-lint-main/srpm-builds/08563847/builder-live.log.gz ↩
https://copr.fedorainfracloud.org/coprs/packit/ansible-ansible-lint-main/build/8563847/ ↩
https://github.com/ansible/ansible-lint/blob/395b674bbc78bc4d9da641c38a7e959b4993d9a4/.packit.yaml#L8 ↩