Added pre-commit hook config #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From what I've tested so far, the workflow is:
There's still one issue I need to resolve, the first invocation of the hook fails, but the second time 'just works (TM)'. I'm not yet sure why EDIT: That's working as designed: pre-commit/pre-commit#532 |
shanemcd
reviewed
May 24, 2023
| @@ -332,6 +332,8 @@ def gpg_sign(self): | |||
| elif "ANSIBLE_SIGN_GPG_PASSPHRASE" in os.environ: | |||
| self.logger.debug("Taking GPG key passphrase from ANSIBLE_SIGN_GPG_PASSPHRASE env var") | |||
| passphrase = os.environ["ANSIBLE_SIGN_GPG_PASSPHRASE"] | |||
| elif "GPG_TTY" in os.environ: | |||
There was a problem hiding this comment.
Can you please pull this out into a separate PR?
|
Continue in #44 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I added a config file for pre-commit (https://pre-commit.com) to allow users to automatically sign their code when making commits.
I had to make a small edit (of which I'm not sure if it can break anything), if GPG_TTY is already set and
-pis not provided to not change it.