ensure virtualenv is installed before bindep run #458
Conversation
| @@ -1,6 +1,12 @@ | |||
| --- | |||
| - hosts: controller | |||
| tasks: | |||
| - name: Ensure virtualenv package is installed -- See https://review.opendev.org/#/c/727413/ | |||
There was a problem hiding this comment.
So for this, I think we it would be best to make this condition on AWS. One idea I have, is we create a nodeset group_var, for appliance but some how reference aws. That way, this only runs on aws nodes, and not modify DIBs.
There was a problem hiding this comment.
What do we need to make the AWS node reach parity with a DIB image?
There was a problem hiding this comment.
realistically, take DIB image, export as AMI and upload it. That would be best solution, but that required work to happen.
That's why I think making this condition is a good step to avoid unneeded DIB config changes
There was a problem hiding this comment.
Yeah, I agree. Now the block is only enabled on aws, so we will avoid any side effects.
Bindep uses the `virtualenv` command. See: https://review.opendev.org/#/c/727413/ Signed-off-by: Gonéri Le Bouder <[email protected]>
Bindep uses the
virtualenvcommand.