ec2_group.py and --diff

[jbscare]

ISSUE TYPE

• Feature Idea

COMPONENT NAME

ec2_group

ANSIBLE VERSION

ansible 2.1.0 (devel 33f96edcd0) last updated 2016/03/10 14:52:58 (GMT -400)
  lib/ansible/modules/core: (detached HEAD c86a0ef84a) last updated 2016/03/10 14:53:03 (GMT -400)
  lib/ansible/modules/extras: (detached HEAD 33a557cc59) last updated 2016/03/10 14:53:03 (GMT -400)
  config file = 
  configured module search path = Default w/o overrides

CONFIGURATION

n/a

OS / ENVIRONMENT

n/a

SUMMARY

ec2_group.py doesn't do anything useful with --diff, and it'd be great if it did (and if it worked both with and without --check). Without it, we have to resort to before-and-after captures of 'aws ec2 describe-security-groups' output, and even that only tells what changed after the change was already made.

STEPS TO REPRODUCE

Adding --diff to an ansible-playbook run that uses the ec2_group module would show output indicating what was changed (or would be changed, with --check) -- perhaps Unix 'diff' style, perhaps some other format if 'diff' style doesn't really make sense. (I don't have a specific idea in mind, but would be happy to help come up with something and/or comment on something that others come up with.)

EXPECTED RESULTS

Some sort of output indicating what had change (or would changed).

ACTUAL RESULTS

Currently there's no change in output from when the playbook is run with or without --diff.

[jbscare]

From @defionscode on March 14, 2016 19:33

This is a great idea. TBH, this is not something I'd likely hit anytime soon given other priorities but I would definitely like to see this implemented.

[jbscare]

From @alikins on April 25, 2016 22:10

Would the proposed ec2_group facts modules help?

ansible/ansible-modules-extras#1939
ansible/ansible-modules-extras#1352
ansible/ansible-modules-extras#1908

[jbscare]

From @ansibot on July 31, 2016 14:43

@ansible, ping. This issue is still waiting on your response.
click here for bot help

[jbscare]

ec2_group_facts would be another way to compare the live state before and after a change, but what I really had in mind here was a way to compare what ec2_group.py would do, against the live state, ideally in a way that would work with --check.

[jbscare]

From @ansibot on August 30, 2016 19:53

@ansible, ping. This issue is still waiting on your response.
click here for bot help

[jbscare]

From @ansibot on October 6, 2016 14:57

@ansible, ping. This issue is still waiting on your response.
click here for bot help

[jbscare]

From @ansibot on December 7, 2016 19:8

This repository has been locked. All new issues and pull requests should be filed in https://github.com/ansible/ansible

Please read through the repomerge page in the dev guide. The guide contains links to tools which automatically move your issue or pull request to the ansible/ansible repo.

[ansibot]

@jbscare Greetings! Thanks for taking the time to open this issue. In order for the community to handle your issue effectively, we need a bit more information.

Here are the items we could not find in your description:

• component name

Please set the description of this issue with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/ISSUE_TEMPLATE.md

click here for bot help

[ansibot]

cc @adq
click here for bot help

[kenske]

Any updates or workaround for this?

[ansibot]

cc @willthames
click here for bot help

[s-hertel]

Hi @jbscare and @kenske. I added a tentative solution for diff mode to ec2_group in 2.7 in 79ecb4c. It's part of a larger goal to create a common diff mode framework for AWS modules, so the output may still needs some tweaking to meet people's needs. Please test it out if you have a chance and open bug reports to help steer the direction it goes in if you find things that can be improved.