Skip to content
This repository has been archived by the owner on Oct 30, 2018. It is now read-only.

Adding new ec2 security group facts module. #1939

Closed
wants to merge 2 commits into from
Closed

Adding new ec2 security group facts module. #1939

wants to merge 2 commits into from

Conversation

shousper
Copy link

@shousper shousper commented Apr 1, 2016

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

ec2_group_facts

ANSIBLE VERSION
ansible 2.0.1.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = Default w/o overrides
SUMMARY

New module provides EC2 security group facts via boto3.

Implementation essentially exposes the same features as the boto3 API for describe_security_groups, including group names, ids and the filters.

@gregdek
Copy link
Contributor

gregdek commented Apr 1, 2016

Thanks @shousper for this new module. When this module receives 'shipit' comments from two community members and any 'needs_revision' comments have been resolved, we will mark for inclusion.

[This message brought to you by your friendly Ansibull-bot.]

@MichaelBaydoun
Copy link
Contributor

There are three new module pull requests, including this one, that seem to cover the same functionality
#1939
#1908
#1352

@wimnat
Copy link
Contributor

wimnat commented Apr 5, 2016

I've already reviewed #1908. Can we close this one?

@gregdek
Copy link
Contributor

gregdek commented May 4, 2016

Thanks @shousper for this PR. This PR requires revisions, either because it fails to build or by reviewer request. Please make the suggested revisions. When you are done, please comment with text 'ready_for_review' and we will put this PR back into review.

[This message brought to you by your friendly Ansibull-bot.]

@gregdek
Copy link
Contributor

gregdek commented May 20, 2016

@shousper A friendly reminder: this pull request has been marked as needing your action. If you still believe that this PR applies, and you intend to address the issues with this PR, just let us know in the PR itself and we will keep it open pending your changes. When you do address the issues, please respond with ready_for_review in your comment, so that we can notify the maintainer.

[This message brought to you by your friendly Ansibull-bot.]

@gregdek
Copy link
Contributor

gregdek commented Jun 4, 2016

@shousper Another friendly reminder: this pull request has been marked as needing your action. If you still believe that this PR applies, and you intend to address the issues with this PR, just let us know in the PR itself and we will keep it open. If you have addressed the issues and believe it's ready for review, please comment with the text "ready_for_review". If we don't hear from you within another 14 days, we will close this pull request.

[This message brought to you by your friendly Ansibull-bot.]

@gregdek
Copy link
Contributor

gregdek commented Jun 20, 2016

@shousper A friendly reminder: this pull request has been marked as needing your action. If you still believe that this PR applies, and you intend to address the issues with this PR, just let us know in the PR itself and we will keep it open pending your changes. When you do address the issues, please respond with ready_for_review in your comment, so that we can notify the maintainer.

[This message brought to you by your friendly Ansibull-bot.]

@gregdek
Copy link
Contributor

gregdek commented Jul 5, 2016

@shousper Another friendly reminder: this pull request has been marked as needing your action. If you still believe that this PR applies, and you intend to address the issues with this PR, just let us know in the PR itself and we will keep it open. If you have addressed the issues and believe it's ready for review, please comment with the text "ready_for_review". If we don't hear from you within another 14 days, we will close this pull request.

[This message brought to you by your friendly Ansibull-bot.]

@shousper
Copy link
Author

shousper commented Jul 6, 2016

Others appear to be working on better solutions. I'll close this off.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants