module_defaults for yum do not get picked up when invoked via package

[johnbui423]

SUMMARY

In 2.10.x, module_defaults for yum do not get picked up when invoked via package. It works fine with 2.9.x.

This seems to be a regression of #57482 - basing this bug report largely on that original issue.

ISSUE TYPE

• Bug Report

COMPONENT NAME

module_defaults

ANSIBLE VERSION

ansible 2.10.3

OS / ENVIRONMENT

CentOS 7

STEPS TO REPRODUCE

---

- hosts: localhost
  module_defaults:
    yum:
      lock_timeout: 120
  tasks:
    - package:
        name: yum
        state: present
    - yum:
        name: yum
        state: present

EXPECTED RESULTS

lock_timeout is set to 120 for both tasks

ACTUAL RESULTS

[...]
TASK [package]
[...]
            "lock_timeout": 30, 
[...]
}

TASK [yum] 
[...]
            "lock_timeout": 120,
[...]

[sivel]

The problem lies here:

ansible/lib/ansible/plugins/action/package.py

Lines 73 to 76 in a24f51d

	# get defaults for specific module
	new_module_args = get_action_args_with_defaults(
	module, new_module_args, self._task.module_defaults, self._templar, self._task._ansible_internal_redirect_list
	)

self._task._ansible_internal_redirect_list only references ['package'], so the defaults are never applied.

We may have to extract this logic into some form of helper so that we can use it to build a list based on the selected action/module:

ansible/lib/ansible/parsing/mod_args.py

Lines 308 to 315 in da60525

	# If the plugin is resolved and redirected smuggle the list of candidate names via the task attribute 'internal_redirect_list'
	context = action_loader.find_plugin_with_context(item, collection_list=self._collection_list)
	if not context.resolved:
	context = module_loader.find_plugin_with_context(item, collection_list=self._collection_list)
	if context.resolved and context.redirect_list:
	self.internal_redirect_list = context.redirect_list
	elif context.redirect_list:
	self.internal_redirect_list = context.redirect_list

I'm not sure that we can just pass [module] instead of an actual internal redirect list.

This issue will likely affect:

• lib/ansible/plugins/action/package.py
• lib/ansible/plugins/action/service.py
• lib/ansible/plugins/action/gather_facts.py