powershell - fix quoting values #71411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.11
bug
samdoran
removed
the
needs_triage
jborean93
added a commit
to jborean93/ansible
that referenced
this pull request
Aug 25, 2020
* powershell - fix quoting values * Add ignore for smart quote skip (cherry picked from commit 72a7cb4)
jborean93
added a commit
to jborean93/ansible
that referenced
this pull request
Aug 25, 2020
* powershell - fix quoting values * Add ignore for smart quote skip (cherry picked from commit 72a7cb4)
This was referenced Aug 25, 2020
nitzmahone
pushed a commit
that referenced
this pull request
Aug 28, 2020
relrod
pushed a commit
that referenced
this pull request
Aug 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When internal functions use the
_escape()function in the PowerShell plugin it was being embedded into a mixture of strings that were either single or double quoted. This fixes up the usage of these values ot use single quotes as it is safer and to ensure we properly escape the 5 chars that need to be escaped.Fixes #62781
ISSUE TYPE
COMPONENT NAME
powershell
winrm
psrp