Add BaseModel class to help auto generate attribute accessors

[bzwei]

The BaseModel class is borrowed from our armrest gem. It automatically converts all hash attributes to instance methods. It can preserve named list of hash attribute from being converted. So far I don't know which attributes need to remain as hash.

With this work module InstanceMethods is no longer needed.

Update: attributes that appear in the related field will be treated as ids. So job_template, inventory, cloud_credential, project etc will be automatically appended with _id.

[gmcculloug]

@bdunne @syncrou Please review.

[syncrou]

What is the best way to implement a mapping back to @inventory_id?

[bzwei]

You can define your own method for particular model, for example

def inventory_id
  __getobj__['inventory']
end

The auto generated inventory method still exists and returns the same thing.

[syncrou]

👍 LGTM - Except in regards to the removed inventory_id attribute for Group, Host - I thought the app was expecting a return on that method. If not - I'm set.

[bzwei]

@syncrou If inventory_id is already used in manageiq app, then we need to update manageiq also. Or we can add back inventory_id method.

[bdunne]

@bzwei Should we extract MiqHashStruct to more_core_extensions and use it as a superclass for BaseModel? I think that would simplify the code in BaseModel.

[bdunne]

@bzwei I'm still stuck on AnsibleTowerClient::Host#inventory.class returning Integer rather than AnsibleTowerClient::Inventory.

[bzwei]

@bdunne @syncrou Update: attributes that appear in the related field will be treated as ids. So job_template, inventory, cloud_credential, project etc will be automatically appended with _id.

[miq-bot]

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

[bzwei]

@bdunne @syncrou please review and merge.

[syncrou]

@bzwei - 👍

[bdunne]

Why is json optional?

[bdunne]

@bzwei I think this PR is getting much closer. I still think we should split BaseModel into:

• BaseModel with an initialize method that filters what attribute methods should be defined and
• its underlying ReadOnlyHashStruct

Does anyone else have an opinion? @Fryguy @gmcculloug @syncrou

[bdunne]

Also, If BaseModel is split, the ReadOnlyHashStruct can do something very similar to MiqHashStruct using method_missing and respond_to_missing? to hit:[]. I think that will simplify the code a lot and remove the need for the instance_eval and define_method lines.

[bzwei]

@bdunne the nice thing with this implementation is that it is more like a real class. You can call #methods(false) to get all new methods it added based on the hash.

[miq-bot]

Checked commit bzwei@a1489e8 with ruby 2.2.3, rubocop 0.37.2, and haml-lint 0.16.1
13 files checked, 3 offenses detected

lib/ansible_tower_client/hash_model.rb

• 🔶 - Line 96, Col 5 - Style/Alias - Use alias instead of alias_method in a class body.
• 🔶 - Line 102, Col 5 - Style/Alias - Use alias instead of alias_method in a class body.
• 🔶 - Line 115, Col 5 - Style/Alias - Use alias instead of alias_method in a class body.