Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

Add job_events to job class and remove job_plays #85

Merged
merged 1 commit into from
Apr 13, 2017

Conversation

bzwei
Copy link
Contributor

@bzwei bzwei commented Apr 12, 2017

Job play is a one type of job events. It is up to the application to make filtering through the options to get job plays from job events.

Job plays are thus deprecated and removed from the gem.

https://www.pivotaltracker.com/story/show/143606153

@syncrou
Copy link
Contributor

syncrou commented Apr 13, 2017

@bzwei - I believe we can pull this out too - https://github.com/ansible/ansible_tower_client_ruby/blob/master/spec/factories/responses.rb#L48

Job play is a one type of job events
@miq-bot
Copy link
Collaborator

miq-bot commented Apr 13, 2017

Checked commit bzwei@afd2225 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
4 files checked, 0 offenses detected
Everything looks good. ⭐

@syncrou
Copy link
Contributor

syncrou commented Apr 13, 2017

@bzwei - One more question - Should this be pulled out too? -https://github.com/ansible/ansible_tower_client_ruby/blob/master/lib/ansible_tower_client/collection.rb#L68-L70 - We no longer need to override types like we had to for job_plays - so the klass || statement is no longer needed - nor is passing the klass for each new collection.

@bzwei
Copy link
Contributor Author

bzwei commented Apr 13, 2017

@syncrou I think we can leave it as now in case we need similar handling for other cases in the future.

@bdunne
Copy link
Contributor

bdunne commented Apr 13, 2017

@bzwei What else needs to override type?

@bzwei
Copy link
Contributor Author

bzwei commented Apr 13, 2017

@bdunne @syncrou We may not have the case that needs overriding at this moment. I think it gives us the flexibility. We came up the solution with some effects. Keeping it here so that we don't need to reinvent if the such need comes.

@bdunne bdunne merged commit 1a56e64 into ansible:master Apr 13, 2017
@bzwei bzwei deleted the job_events branch April 17, 2017 18:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants