Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pod_labels for custom pod labels #676

Closed
wants to merge 1 commit into from

Conversation

locmai
Copy link

@locmai locmai commented Nov 29, 2021

Adding pod_labels option for templating custom labels into the pods.

This could simply solve the #242 since users could add the aadpodbinding label and other use cases.

Signed-off-by: Loc Mai [email protected]

@hungtran84
Copy link
Contributor

great @locmai , exactly what i was looking for.
Related issue #242

@kdelee
Copy link
Member

kdelee commented Nov 29, 2021

Can you confirm that these pod labels are applied to the podspec for the default container group as well? if you could paste ${TOWER_URL}/api/v2/instance_groups/${ID OF DEFAULT CONTAINER GROUP}/ that would make it clear if the pod labels get applied to both the awx pods as well as the default container group

@kdelee
Copy link
Member

kdelee commented Nov 29, 2021

I'm 99% certain this won't fix applying labels to the default container group. I think we need something like ansible/awx#11395 for it to filter through to the default container group, which is what is actually used for jobs (what you have would apply only the awx deployment itself). I'm not saying this is a bad change, just maybe won't do everything desired

@locmai
Copy link
Author

locmai commented Dec 6, 2021

@kdelee Your PR looks better and makes more sense. I didn't look at this close enough, though it was just an easy config change. Closing this PR now.

@locmai locmai closed this Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants