Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix up ansible-test sanity checks due to ansible 2.17 release #15208

Merged
merged 6 commits into from
May 21, 2024
Merged

Fix up ansible-test sanity checks due to ansible 2.17 release #15208

merged 6 commits into from
May 21, 2024

Conversation

fosterseth
Copy link
Member

@fosterseth fosterseth commented May 21, 2024 •
edited
Loading

SUMMARY

Address the following ansible sanity errors

ERROR: Found 7 pylint issue(s) which need to be resolved:
ERROR: plugins/module_utils/controller_api.py:110:15: unidiomatic-typecheck: Use isinstance() rather than type() for a typecheck.
ERROR: plugins/module_utils/controller_api.py:218:23: unidiomatic-typecheck: Use isinstance() rather than type() for a typecheck.
ERROR: plugins/module_utils/controller_api.py:260:23: unidiomatic-typecheck: Use isinstance() rather than type() for a typecheck.
ERROR: plugins/modules/ad_hoc_command.py:166:39: unidiomatic-typecheck: Use isinstance() rather than type() for a typecheck.
ERROR: plugins/modules/import.py:59:4: unused-import: Unused EXPORTABLE_RESOURCES imported from awxkit.api.pages.api
ERROR: test/awx/conftest.py:22:0: unused-import: Unused credentialtype_scm imported from awx.main.tests.functional.conftest
ERROR: test/awx/conftest.py:22:0: unused-import: Unused credentialtype_ssh imported from awx.main.tests.functional.conftest

ERROR: Found 14 validate-modules issue(s) which need to be resolved:
ERROR: plugins/modules/export.py:0:0: nonexistent-parameter-documented: Argument 'applications' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
ERROR: plugins/modules/export.py:0:0: nonexistent-parameter-documented: Argument 'credential_types' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
ERROR: plugins/modules/export.py:0:0: nonexistent-parameter-documented: Argument 'credentials' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
ERROR: plugins/modules/export.py:0:0: nonexistent-parameter-documented: Argument 'execution_environments' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
ERROR: plugins/modules/export.py:0:0: nonexistent-parameter-documented: Argument 'inventory' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
ERROR: plugins/modules/export.py:0:0: nonexistent-parameter-documented: Argument 'inventory_sources' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
ERROR: plugins/modules/export.py:0:0: nonexistent-parameter-documented: Argument 'job_templates' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
ERROR: plugins/modules/export.py:0:0: nonexistent-parameter-documented: Argument 'notification_templates' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
ERROR: plugins/modules/export.py:0:0: nonexistent-parameter-documented: Argument 'organizations' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
ERROR: plugins/modules/export.py:0:0: nonexistent-parameter-documented: Argument 'projects' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
ERROR: plugins/modules/export.py:0:0: nonexistent-parameter-documented: Argument 'schedules' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
ERROR: plugins/modules/export.py:0:0: nonexistent-parameter-documented: Argument 'teams' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
ERROR: plugins/modules/export.py:0:0: nonexistent-parameter-documented: Argument 'users' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
ERROR: plugins/modules/export.py:0:0: nonexistent-parameter-documented: Argument 'workflow_job_templates' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • Collection
AWX VERSION
awx: 24.3.1.dev22+g805e06ed2c.d20240521

@github-actions github-actions bot added the component:awx_collection issues related to the collection for controlling AWX label May 21, 2024
@fosterseth fosterseth requested a review from TheRealHaoLiu May 21, 2024 03:30
@fosterseth fosterseth force-pushed the fix_ansible_sanity branch from 805e06e to 37e91f9 Compare May 21, 2024 03:30
@fosterseth fosterseth force-pushed the fix_ansible_sanity branch from 37e91f9 to 1d4769e Compare May 21, 2024 03:31
gundalow
gundalow previously requested changes May 21, 2024
View reviewed changes
awx_collection/plugins/modules/export.py Outdated Show resolved Hide resolved
@TheRealHaoLiu TheRealHaoLiu changed the title Fix up ansible-test sanity checks Fix up ansible-test sanity checks due to ansible 2.1.7 May 21, 2024
@TheRealHaoLiu TheRealHaoLiu changed the title Fix up ansible-test sanity checks due to ansible 2.1.7 Fix up ansible-test sanity checks due to ansible 2.17 release May 21, 2024
TheRealHaoLiu and others added 3 commits May 21, 2024 10:57
@TheRealHaoLiu
Fix awx-collection test failure
527cbab 
```
fixture 'credentialtype_ssh' not found
```
@TheRealHaoLiu
Fix module adhoc command extra string-ify
8b37cfe 
example failure
```
<testhost> EXEC /bin/sh -c '/usr/bin/python3 && sleep 0'
fatal: [testhost]: FAILED! => {
    "changed": false,
    "invocation": {
        "module_args": {
            "become_enabled": null,
            "controller_config_file": null,
            "controller_host": null,
            "controller_oauthtoken": null,
            "controller_password": null,
            "controller_username": null,
            "credential": "AWX-Collection-tests-ad_hoc_command-ssh-cred-ThLYQcDoJvqKDIzL",
            "diff_mode": null,
            "execution_environment": null,
            "extra_vars": {
                "var1": "test var"
            },
            "forks": null,
            "interval": 2.0,
            "inventory": "Demo Inventory",
            "job_type": null,
            "limit": null,
            "module_args": null,
            "module_name": "ping",
            "request_timeout": null,
            "timeout": null,
            "validate_certs": null,
            "verbosity": null,
            "wait": true
        }
    },
    "msg": "Failed to launch command, see response for details",
    "response": {
        "json": {
            "extra_vars": [
                "Not a valid string."
            ]
        },
        "status_code": 400
    }
}
```
@fosterseth
import EXPORTABLE_RESOURCES
6885601 
Signed-off-by: Seth Foster <[email protected]>
@TheRealHaoLiu TheRealHaoLiu requested a review from gundalow May 21, 2024 15:27
@TheRealHaoLiu
Copy link
Member

closing and reopen to trigger CI... github action runners seems to be struggling today?

@TheRealHaoLiu TheRealHaoLiu reopened this May 21, 2024
@fosterseth
spaces
b5f3d9f 
Signed-off-by: Seth Foster <[email protected]>
@TheRealHaoLiu TheRealHaoLiu merged commit 0d4f653 into ansible:devel May 21, 2024
20 of 21 checks passed
djyasin pushed a commit to djyasin/awx that referenced this pull request Sep 16, 2024
@fosterseth @TheRealHaoLiu @djyasin
Fix up ansible-test sanity checks due to ansible 2.17 release (ansibl…
01da2d7 
…e#15208)

* Fix up ansible sanity checks

* Fix awx-collection test failure

* Add ignore for ansible-test 2.17 

---------

Signed-off-by: Seth Foster <[email protected]>
Co-authored-by: Hao Liu <[email protected]>
djyasin pushed a commit to djyasin/awx that referenced this pull request Nov 11, 2024
@fosterseth @TheRealHaoLiu @djyasin
Fix up ansible-test sanity checks due to ansible 2.17 release (ansibl…
2d20306 
…e#15208)

* Fix up ansible sanity checks

* Fix awx-collection test failure

* Add ignore for ansible-test 2.17 

---------

Signed-off-by: Seth Foster <[email protected]>
Co-authored-by: Hao Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanCoding AlanCoding AlanCoding left review comments

@TheRealHaoLiu TheRealHaoLiu TheRealHaoLiu approved these changes

@thedoubl3j thedoubl3j thedoubl3j approved these changes

@gundalow gundalow Awaiting requested review from gundalow

Assignees
No one assigned
Labels
component:awx_collection issues related to the collection for controlling AWX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fosterseth @TheRealHaoLiu @gundalow @AlanCoding @thedoubl3j