Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Manual" option from search filters #6110

Merged

Conversation

keithjgrant
Copy link
Member

SUMMARY

Removes "Manual" option from the Inventory Sources & Project search bar filters, as this value has been deprecated.

Additionally, I updated the qs utils to handle an empty string parameter — Manual was an empty string for these search filters, which surfaced these bugs before they were removed.

addresses #5963

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • UI

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

Copy link
Contributor

@jlmitch5 jlmitch5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice fix

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit fe046b4 into ansible:devel Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants